svn commit: r261601 - in head: sys/net sys/netinet sys/netinet6 usr.bin/netstat

[Gleb Smirnoff]

On Fri, Feb 07, 2014 at 03:34:27PM +0000, Bjoern A. Zeeb wrote:
B> >  * XXX This does not end up updating timeouts at runtime
B> >  * and only reflects the value for the last table added :-/
B> >  */
B> > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, syn_expire, CTLFLAG_RW,
B> > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, syn_expire, CTLFLAG_RW,
B> >     &VNET_NAME(flowtable_syn_expire), 0,
B> >     "seconds after which to remove syn allocated flow.");
B> > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, udp_expire, CTLFLAG_RW,
B> > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, udp_expire, CTLFLAG_RW,
B> >     &VNET_NAME(flowtable_udp_expire), 0,
B> >     "seconds after which to remove flow allocated to UDP.");
B> > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, fin_wait_expire, CTLFLAG_RW,
B> > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, fin_wait_expire, CTLFLAG_RW,
B> >     &VNET_NAME(flowtable_fin_wait_expire), 0,
B> >     "seconds after which to remove a flow in FIN_WAIT.");
B> > -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, tcp_expire, CTLFLAG_RW,
B> > +SYSCTL_VNET_INT(_net_flowtable, OID_AUTO, tcp_expire, CTLFLAG_RW,
B> >     &VNET_NAME(flowtable_tcp_expire), 0,
B> >     "seconds after which to remove flow allocated to a TCP connection.");
B> …
B> 
B> 
B> This is not what we are doing for a lot of other things in the tree which simply treat “inet” as “IP” without version number.  Now I know that the floatable sits even between L3 and L2 given it caches pairs, I am still not sure I want to make net.* the “dumping ground” for these.

And that's not nice that we are using "inet" as dumping ground for all kind of IP.

B> Pending a better solution I don’t care apart from that sysctl.confs entries for the people using floatable after all break with this.

Taking into account absence of FLOWTABLE in GENERIC and all the problems that
were (are?) there, I'm pretty sure these people are empty set :)

-- 
Totus tuus, Glebius.