svn commit: r269452 - stable/10/sys/fs/nfsserver

Rick Macklem rmacklem at
Sun Aug 3 00:35:11 UTC 2014

Author: rmacklem
Date: Sun Aug  3 00:35:10 2014
New Revision: 269452

  MFC: r268273
  The new NFSv3 server did not generate directory postop attributes for
  the reply to ReaddirPlus when the server failed within the loop
  that calls VFS_VGET(). This failure is most likely an error
  return from VFS_VGET() caused by a bogus d_fileno that was
  truncated to 32bits.
  This patch fixes the server so that it will return directory postop
  attributes for the failure. It does not fix the underlying issue caused
  by d_fileno being uint32_t when a file system like ZFS generates
  a fileno that is greater than 32bits.

Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/fs/nfsserver/nfs_nfsdport.c
--- stable/10/sys/fs/nfsserver/nfs_nfsdport.c	Sun Aug  3 00:29:03 2014	(r269451)
+++ stable/10/sys/fs/nfsserver/nfs_nfsdport.c	Sun Aug  3 00:35:10 2014	(r269452)
@@ -2264,9 +2264,11 @@ again:
 	if (dirlen > cnt || nd->nd_repstat) {
 		if (!nd->nd_repstat && entrycnt == 0)
 			nd->nd_repstat = NFSERR_TOOSMALL;
-		if (nd->nd_repstat)
+		if (nd->nd_repstat) {
 			newnfs_trimtrailing(nd, mb0, bpos0);
-		else
+			if (nd->nd_flag & ND_NFSV3)
+				nfsrv_postopattr(nd, getret, &at);
+		} else
 			newnfs_trimtrailing(nd, mb1, bpos1);
 		eofflag = 0;
 	} else if (cpos < cend)

More information about the svn-src-all mailing list