svn commit: r264988 - head/sys/amd64/vmm/intel

Neel Natu neel at FreeBSD.org
Sat Apr 26 22:37:57 UTC 2014


Author: neel
Date: Sat Apr 26 22:37:56 2014
New Revision: 264988
URL: http://svnweb.freebsd.org/changeset/base/264988

Log:
  A VMCS is always inactive when it exits the vmx_run() loop.
  Remove redundant code and the misleading comment that suggest otherwise.
  
  Reviewed by:	grehan@

Modified:
  head/sys/amd64/vmm/intel/vmx.c

Modified: head/sys/amd64/vmm/intel/vmx.c
==============================================================================
--- head/sys/amd64/vmm/intel/vmx.c	Sat Apr 26 22:32:04 2014	(r264987)
+++ head/sys/amd64/vmm/intel/vmx.c	Sat Apr 26 22:37:56 2014	(r264988)
@@ -2234,7 +2234,7 @@ vmx_run(void *arg, int vcpu, register_t 
 static void
 vmx_vmcleanup(void *arg)
 {
-	int i, error;
+	int i;
 	struct vmx *vmx = arg;
 
 	if (apic_access_virtualization(vmx, 0))
@@ -2243,13 +2243,6 @@ vmx_vmcleanup(void *arg)
 	for (i = 0; i < VM_MAXCPU; i++)
 		vpid_free(vmx->state[i].vpid);
 
-	/*
-	 * XXXSMP we also need to clear the VMCS active on the other vcpus.
-	 */
-	error = vmclear(&vmx->vmcs[0]);
-	if (error != 0)
-		panic("vmx_vmcleanup: vmclear error %d on vcpu 0", error);
-
 	free(vmx, M_VMX);
 
 	return;


More information about the svn-src-all mailing list