svn commit: r264269 - in head: sys/conf sys/kern sys/modules sys/modules/imgact_binmisc sys/sys usr.sbin usr.sbin/binmiscctl

[John-Mark Gurney]

Sean Bruno wrote this message on Tue, Apr 08, 2014 at 15:01 -0700:
> > > Added:
> > >   head/sys/kern/imgact_binmisc.c   (contents, props changed)
> > >   head/sys/modules/imgact_binmisc/
> > >   head/sys/modules/imgact_binmisc/Makefile   (contents, props changed)
> > >   head/sys/sys/imgact_binmisc.h   (contents, props changed)
> > >   head/usr.sbin/binmiscctl/
> > >   head/usr.sbin/binmiscctl/Makefile   (contents, props changed)
> > >   head/usr.sbin/binmiscctl/binmiscctl.8   (contents, props changed)
> > >   head/usr.sbin/binmiscctl/binmiscctl.c   (contents, props changed)
> > > Modified:
> > >   head/sys/conf/files.amd64
> > >   head/sys/conf/files.i386
> > >   head/sys/modules/Makefile
> > >   head/usr.sbin/Makefile
> > 
> > Maybe put it in sys/conf/files instead of only amd64|i386?  You enabled
> > the module build for all architectures.  Please also add it to sys/conf/NOTES.
> 
> 
> I've adjusted things to only build on amd64/i386.  Thank you for
> pointing out my misconfiguration.
> 
> I've updated NOTES as well at svn r264280 to reflext this and updated
> options for amd64/i386.
> 
> I haven't tested on non-x86 h/w and have no idea if it works or not. I
> didn't feel comfortable building this driver in the non-x86 case.  If
> there is a use case/tester for the other arch's, I'll be more than happy
> to change this.

Can we make sure that this choice is well documented?  Too often things
are marked for a particular arch w/o notice why it is limited, and this
just continues to make non-i386/amd64 arches harder to become first
class citzens as people will say feature X is broken on arch Y for no
good reason...

If you believe it should work on all archs, make it available for all
and send out a call for testers to the various lists...

Thanks.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."