svn commit: r255804 - in head/contrib/llvm/lib: CodeGen/SelectionDAG Target/AArch64 Target/ARM Target/Hexagon Target/MSP430 Target/Mips Target/NVPTX Target/PowerPC Target/R600 Target/Sparc Target/S...

Dimitry Andric dim at FreeBSD.org
Sun Sep 22 22:05:27 UTC 2013


On Sep 23, 2013, at 00:03, Dimitry Andric <dim at FreeBSD.org> wrote:
> Author: dim
> Date: Sun Sep 22 22:03:30 2013
> New Revision: 255804
> URL: http://svnweb.freebsd.org/changeset/base/255804
> 
> Log:
>  Pull in r191165 from upstream llvm trunk:
> 
>    ISelDAG: spot chain cycles involving MachineNodes
> 
>    Previously, the DAGISel function WalkChainUsers was spotting that it
>    had entered already-selected territory by whether a node was a
>    MachineNode (amongst other things). Since it's fairly common practice
>    to insert MachineNodes during ISelLowering, this was not the correct
>    check.
> 
>    Looking around, it seems that other nodes get their NodeId set to -1
>    upon selection, so this makes sure the same thing happens to all
>    MachineNodes and uses that characteristic to determine whether we
>    should stop looking for a loop during selection.
> 
>    This should fix PR15840.
> 
>  Specifically, this fixes the long-standing assertion failure when
>  compiling the multimedia/gstreamer port on i386.  Thanks to Tijl
>  Coosemans for his help in getting upstream to fix it.
> 
>  Approved by:	re (marius)

MFC after:	3 days

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20130923/e714dd6a/attachment.sig>


More information about the svn-src-all mailing list