svn commit: r255783 - head/sys/kern
Justin T. Gibbs
gibbs at FreeBSD.org
Sun Sep 22 03:46:34 UTC 2013
On Sep 21, 2013, at 9:34 PM, Nathan Whitehorn <nwhitehorn at freebsd.org> wrote:
> On 09/21/13 21:46, Justin T. Gibbs wrote:
>> Author: gibbs
>> Date: Sun Sep 22 02:46:13 2013
>> New Revision: 255783
>> URL: http://svnweb.freebsd.org/changeset/base/255783
>>
>> Log:
>> Fix ia64 and mips kernel builds due to XENHVM=>GENERIC integration in
>> revision 255744.
>> sys/kern/subr_smp.c:
>> IPI_SUSPEND is only available on amd64 and i386. Protect
>> new uses of this constant with #ifdefs to avoid impacting
>> other platforms.
>
> Would it make more sense just to add this to other platforms? It needn't actually be sent, of course, and it would cut down on platform-specific #ifdef in MI code, which is universally a good thing.
> -Nathan
Sure. But the build was broken and I opted to restore the status quo rather than take the more time consuming path of trying to clean up all of the other #ifdefs and then having to reverify builds on all supported platforms.
--
Justin
More information about the svn-src-all
mailing list