svn commit: r255360 - head/sys/net

[Davide Italiano]

On Sun, Sep 8, 2013 at 6:26 PM, Ed Schouten <ed at 80386.nl> wrote:
> 2013/9/7 Davide Italiano <davide at freebsd.org>:
>> Log:
>>   Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate().
>
> Both the tun and the tap driver still use clonelists, right? I'm not
> sure this fix is all right.
>
> --
> Ed Schouten <ed at 80386.nl>

Please correct me if I'm wrong, but from what I see r204464 (by kib@)
removed the set of SI_CHEAPCLONE flag from both if_tap and if_tun so I
think that's just a leftover.
Also, SI_CHEAPCLONE implementation inside devfs is pretty unfinished,
so even though we restore that piece of code inside the driver I'm not
sure it will accomplish anything. Most of the drivers already removed
the usage already.

As a side note, I've already discussed with Kostik how to handle this
in the future and he thinks (and I agree) that the right action there
is to remove clones and SI_CHEAPCLONE, or implement the real
SI_CHEAPCLONE semantic.
I would strongly go for the first option, but if that won't be
technically possible I think we should re-evaluate when/how to
reintroduce the SI_CHEAPCLONE flag inside drivers. I hope this makes
sense to you.

Thanks,

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare