svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit

Ed Schouten ed at 80386.nl
Sun Sep 8 16:24:58 UTC 2013


2013/9/7 Davide Italiano <davide at freebsd.org>:
> Log:
>   - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+
>   dev_ref() in the clone handlers that still use it.
>   - Don't set SI_CHEAPCLONE flag, it's not used anywhere neither in devfs
>   (for anything real)

Wait. This piece of code is never used on FreeBSD HEAD, right? See
dtrace_load.c:

#if __FreeBSD_version < 800039
        /* Enable device cloning. */
        clone_setup(&dtrace_clones);

        /* Setup device cloning events. */
        eh_tag = EVENTHANDLER_REGISTER(dev_clone, dtrace_clone, 0,
1000);
#else
        dtrace_dev = make_dev(&dtrace_cdevsw, 0, UID_ROOT, GID_WHEEL,
0600,
            "dtrace/dtrace");
        helper_dev = make_dev(&helper_cdevsw, 0, UID_ROOT, GID_WHEEL,
0660,
            "dtrace/helper");
#endif

-- 
Ed Schouten <ed at 80386.nl>


More information about the svn-src-all mailing list