svn commit: r255246 - head/sys/sys

[Konstantin Belousov]

On Thu, Sep 05, 2013 at 06:44:39PM +0400, Gleb Smirnoff wrote:
> On Thu, Sep 05, 2013 at 05:03:19PM +0300, Konstantin Belousov wrote:
> K> On Thu, Sep 05, 2013 at 01:46:30PM +0000, Gleb Smirnoff wrote:
> K> > Author: glebius
> K> > Date: Thu Sep  5 13:46:30 2013
> K> > New Revision: 255246
> K> > URL: http://svnweb.freebsd.org/changeset/base/255246
> K> > 
> K> > Log:
> K> >   Fix build.
> K> >   counter.h requires systm.h
> K> > 
> K> > Modified:
> K> >   head/sys/sys/sf_buf.h
> K> > 
> K> > Modified: head/sys/sys/sf_buf.h
> K> > ==============================================================================
> K> > --- head/sys/sys/sf_buf.h	Thu Sep  5 12:56:08 2013	(r255245)
> K> > +++ head/sys/sys/sf_buf.h	Thu Sep  5 13:46:30 2013	(r255246)
> K> > @@ -54,6 +54,7 @@ struct sfstat {				/* sendfile statistic
> K> >  
> K> >  #ifdef _KERNEL
> K> >  #include <machine/sf_buf.h>
> K> > +#include <sys/systm.h>
> K> >  #include <sys/counter.h>
> K> >  struct mbuf;	/* for sf_buf_mext() */
> K> >  
> K> IMO the counter.h (and sfstat, SFSTAT_INC) should be removed from the sf_buf.h.
> 
> The problem is that SFSTAT_INC() is used in MD code.

Then MD code should start including additional header. This is probably
some amount of work, but the current situation is not acceptable. sf
buffers have overgrown the 'sendfile buffers' use case for long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20130906/73884551/attachment.sig>