svn commit: r255192 - in head: contrib/binutils/gas/config contrib/binutils/opcodes sys/amd64/amd64

[John Baldwin]

On Wednesday, September 04, 2013 8:44:30 pm Konstantin Belousov wrote:
> On Wed, Sep 04, 2013 at 07:56:45AM -0400, John Baldwin wrote:
> > On Wednesday, September 04, 2013 12:25:35 am Konstantin Belousov wrote:
> > > On Tue, Sep 03, 2013 at 09:21:47PM +0000, John Baldwin wrote:
> > > > Author: jhb
> > > > Date: Tue Sep  3 21:21:47 2013
> > > > New Revision: 255192
> > > > URL: http://svnweb.freebsd.org/changeset/base/255192
> > > > 
> > > > Log:
> > > >   Add support for the 'invpcid' instruction to binutils and DDB's
> > > >   disassembler on amd64.
> > > >   
> > > >   MFC after:	1 month
> > > 
> > > Nice, thank you.
> > > 
> > > Do you agree with me that it is premature to start using the mnemonics
> > > in the kernel source until the changes are merged into stable/9 at least ?
> > 
> > That is fine.  Can you test that using them directly works fine with GCC?
> > I know clang already supported this instruction.
> 
> Hmm, tried make buildkernel CC=gcc for the world (and builworld area)
> built after your commit.  I get
> 
> gcc -c -x assembler-with-cpp -DLOCORE -O2 -frename-registers -pipe -fno-strict-a
> liasing  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototype
> s  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-point
> er-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   
> -nostdinc  -I. -I/usr/home/kostik/work/build/bsd/DEV/src/sys -I/usr/home/kostik/
> work/build/bsd/DEV/src/sys/contrib/altq -I/usr/home/kostik/work/build/bsd/DEV/sr
> c/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.
> h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-f
> unction-growth=1000  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmod
> el=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind
> -tables -ffreestanding -fstack-protector  -Werror /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/exception.S
> /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S: Assembler messages:
> /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:224: Error: no such instruction: `invpcid (%rdx),%rax'
> /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:312: Error: no such instruction: `invpcid (%rdx),%rax'
> /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:409: Error: no such instruction: `invpcid (%rdx),%rax'
> *** Error code 1

Hmm, I have no idea why this failed. :(  It should definitely be using the
new as after a buildworld.

-- 
John Baldwin