svn commit: r257293 - in head: share/examples/bhyve usr.sbin/bhyve

Neel Natu neel at FreeBSD.org
Tue Oct 29 00:18:15 UTC 2013


Author: neel
Date: Tue Oct 29 00:18:11 2013
New Revision: 257293
URL: http://svnweb.freebsd.org/changeset/base/257293

Log:
  Add support for PCI-to-ISA LPC bridge emulation. If the LPC bus is attached
  to a virtual machine then we implicitly create COM1 and COM2 ISA devices.
  
  Prior to this change the only way of attaching a COM port to the virtual
  machine was by presenting it as a PCI device that is mapped at the legacy
  I/O address 0x3F8 or 0x2F8.
  
  There were some issues with the original approach:
  - It did not work at all with UEFI because UEFI will reprogram the PCI device
    BARs and remap the COM1/COM2 ports at non-legacy addresses.
  - OpenBSD GENERIC kernel does not create a /dev/console because it expects
    the uart device at the legacy 0x3F8/0x2F8 address to be an ISA device.
  - It was functional with a FreeBSD guest but caused the console to appear
    on /dev/ttyu2 which was not intuitive.
  
  The uart emulation is now independent of the bus on which it resides. Thus it
  is possible to have uart devices on the PCI bus in addition to the legacy
  COM1/COM2 devices behind the LPC bus.
  
  The command line option to attach ISA COM1/COM2 ports to a virtual machine is
  "-s <bus>,lpc -l com1,stdio".
  
  The command line option to create a PCI-attached uart device is:
  "-s <bus>,uart[,stdio]"
  
  The command line option to create PCI-attached COM1/COM2 device is:
  "-S <bus>,uart[,stdio]". This style of creating COM ports is deprecated.
  
  Discussed with:	grehan
  Reviewed by:	grehan
  Submitted by:	Tycho Nightingale (tycho.nightingale at pluribusnetworks.com)
  
  M    share/examples/bhyve/vmrun.sh
  AM   usr.sbin/bhyve/legacy_irq.c
  AM   usr.sbin/bhyve/legacy_irq.h
  M    usr.sbin/bhyve/Makefile
  AM   usr.sbin/bhyve/uart_emul.c
  M    usr.sbin/bhyve/bhyverun.c
  AM   usr.sbin/bhyve/uart_emul.h
  M    usr.sbin/bhyve/pci_uart.c
  M    usr.sbin/bhyve/pci_emul.c
  M    usr.sbin/bhyve/inout.c
  M    usr.sbin/bhyve/pci_emul.h
  M    usr.sbin/bhyve/inout.h
  AM   usr.sbin/bhyve/pci_lpc.c
  AM   usr.sbin/bhyve/pci_lpc.h

Added:
  head/usr.sbin/bhyve/legacy_irq.c   (contents, props changed)
  head/usr.sbin/bhyve/legacy_irq.h   (contents, props changed)
  head/usr.sbin/bhyve/pci_lpc.c   (contents, props changed)
  head/usr.sbin/bhyve/pci_lpc.h   (contents, props changed)
  head/usr.sbin/bhyve/uart_emul.c   (contents, props changed)
  head/usr.sbin/bhyve/uart_emul.h   (contents, props changed)
Modified:
  head/share/examples/bhyve/vmrun.sh
  head/usr.sbin/bhyve/Makefile
  head/usr.sbin/bhyve/bhyverun.c
  head/usr.sbin/bhyve/inout.c
  head/usr.sbin/bhyve/inout.h
  head/usr.sbin/bhyve/pci_emul.c
  head/usr.sbin/bhyve/pci_emul.h
  head/usr.sbin/bhyve/pci_uart.c

Modified: head/share/examples/bhyve/vmrun.sh
==============================================================================
--- head/share/examples/bhyve/vmrun.sh	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/share/examples/bhyve/vmrun.sh	Tue Oct 29 00:18:11 2013	(r257293)
@@ -162,7 +162,7 @@ while [ 1 ]; do
 			exit 1
 		fi
 		BOOTDISK=${isofile}
-		installer_opt="-s 3:0,virtio-blk,${BOOTDISK}"
+		installer_opt="-s 31:0,virtio-blk,${BOOTDISK}"
 	else
 		BOOTDISK=${virtio_diskdev}
 		installer_opt=""
@@ -176,10 +176,11 @@ while [ 1 ]; do
 	${FBSDRUN} -c ${cpus} -m ${memsize} ${apic_opt} -AI -H -P	\
 		-g ${gdbport}						\
 		-s 0:0,hostbridge					\
-		-s 1:0,virtio-net,${tapdev}				\
-		-s 2:0,virtio-blk,${virtio_diskdev}			\
+		-s 1:0,lpc						\
+		-s 2:0,virtio-net,${tapdev}				\
+		-s 3:0,virtio-blk,${virtio_diskdev}			\
+		-l com1,stdio						\
 		${installer_opt}					\
-		-S 31,uart,stdio					\
 		${vmname}
 	if [ $? -ne 0 ]; then
 		break

Modified: head/usr.sbin/bhyve/Makefile
==============================================================================
--- head/usr.sbin/bhyve/Makefile	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/Makefile	Tue Oct 29 00:18:11 2013	(r257293)
@@ -7,10 +7,10 @@ PROG=	bhyve
 DEBUG_FLAGS= -g -O0 
 
 SRCS=	acpi.c atpic.c bhyverun.c block_if.c consport.c dbgport.c elcr.c
-SRCS+=  inout.c ioapic.c mem.c mevent.c mptbl.c pci_ahci.c
-SRCS+=	pci_emul.c pci_hostbridge.c pci_passthru.c pci_virtio_block.c
+SRCS+=  inout.c ioapic.c legacy_irq.c mem.c mevent.c mptbl.c pci_ahci.c
+SRCS+=	pci_emul.c pci_hostbridge.c pci_lpc.c pci_passthru.c pci_virtio_block.c
 SRCS+=	pci_virtio_net.c pci_uart.c pit_8254.c pmtmr.c post.c rtc.c
-SRCS+=	virtio.c xmsr.c spinup_ap.c
+SRCS+=	uart_emul.c virtio.c xmsr.c spinup_ap.c
 
 .PATH:	${.CURDIR}/../../sys/amd64/vmm
 SRCS+=	vmm_instruction_emul.c

Modified: head/usr.sbin/bhyve/bhyverun.c
==============================================================================
--- head/usr.sbin/bhyve/bhyverun.c	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/bhyverun.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -54,10 +54,12 @@ __FBSDID("$FreeBSD$");
 #include "acpi.h"
 #include "inout.h"
 #include "dbgport.h"
+#include "legacy_irq.h"
 #include "mem.h"
 #include "mevent.h"
 #include "mptbl.h"
 #include "pci_emul.h"
+#include "pci_lpc.h"
 #include "xmsr.h"
 #include "ioapic.h"
 #include "spinup_ap.h"
@@ -123,7 +125,7 @@ usage(int code)
 
         fprintf(stderr,
                 "Usage: %s [-aehAHIPW] [-g <gdb port>] [-s <pci>] [-S <pci>]\n"
-		"       %*s [-c vcpus] [-p pincpu] [-m mem] <vmname>\n"
+		"       %*s [-c vcpus] [-p pincpu] [-m mem] [-l <lpc>] <vm>\n"
 		"       -a: local apic is in XAPIC mode (default is X2APIC)\n"
 		"       -A: create an ACPI table\n"
 		"       -g: gdb port\n"
@@ -137,6 +139,7 @@ usage(int code)
 		"       -h: help\n"
 		"       -s: <slot,driver,configinfo> PCI slot config\n"
 		"       -S: <slot,driver,configinfo> legacy PCI slot config\n"
+		"       -l: LPC device configuration\n"
 		"       -m: memory size in MB\n",
 		progname, (int)strlen(progname), "");
 
@@ -553,7 +556,7 @@ main(int argc, char *argv[])
 	ioapic = 0;
 	memsize = 256 * MB;
 
-	while ((c = getopt(argc, argv, "abehAHIPWp:g:c:s:S:m:")) != -1) {
+	while ((c = getopt(argc, argv, "abehAHIPWp:g:c:s:S:m:l:")) != -1) {
 		switch (c) {
 		case 'a':
 			disable_x2apic = 1;
@@ -573,6 +576,12 @@ main(int argc, char *argv[])
 		case 'g':
 			gdb_port = atoi(optarg);
 			break;
+		case 'l':
+			if (lpc_device_parse(optarg) != 0) {
+				errx(EX_USAGE, "invalid lpc device "
+				    "configuration '%s'", optarg);
+			}
+			break;
 		case 's':
 			if (pci_parse_slot(optarg, 0) != 0)
 				exit(1);
@@ -640,6 +649,7 @@ main(int argc, char *argv[])
 
 	init_mem();
 	init_inout();
+	legacy_irq_init();
 
 	rtc_init(ctx);
 

Modified: head/usr.sbin/bhyve/inout.c
==============================================================================
--- head/usr.sbin/bhyve/inout.c	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/inout.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -84,7 +84,7 @@ register_default_iohandler(int start, in
 	iop.name = "default";
 	iop.port = start;
 	iop.size = size;
-	iop.flags = IOPORT_F_INOUT;
+	iop.flags = IOPORT_F_INOUT | IOPORT_F_DEFAULT;
 	iop.handler = default_inout;
 
 	register_inout(&iop);
@@ -159,7 +159,18 @@ register_inout(struct inout_port *iop)
 	int i;
 
 	VERIFY_IOPORT(iop->port, iop->size);
-	
+
+	/*
+	 * Verify that the new registration is not overwriting an already
+	 * allocated i/o range.
+	 */
+	if ((iop->flags & IOPORT_F_DEFAULT) == 0) {
+		for (i = iop->port; i < iop->port + iop->size; i++) {
+			if ((inout_handlers[i].flags & IOPORT_F_DEFAULT) == 0)
+				return (-1);
+		}
+	}
+
 	for (i = iop->port; i < iop->port + iop->size; i++) {
 		inout_handlers[i].name = iop->name;
 		inout_handlers[i].flags = iop->flags;

Modified: head/usr.sbin/bhyve/inout.h
==============================================================================
--- head/usr.sbin/bhyve/inout.h	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/inout.h	Tue Oct 29 00:18:11 2013	(r257293)
@@ -46,7 +46,13 @@ struct inout_port {
 };
 #define	IOPORT_F_IN		0x1
 #define	IOPORT_F_OUT		0x2
-#define	IOPORT_F_INOUT		0x3
+#define	IOPORT_F_INOUT		(IOPORT_F_IN | IOPORT_F_OUT)
+
+/*
+ * The following flags are used internally and must not be used by
+ * device models.
+ */
+#define	IOPORT_F_DEFAULT	0x80000000	/* claimed by default handler */
 
 #define	INOUT_PORT(name, port, flags, handler)				\
 	static struct inout_port __CONCAT(__inout_port, __LINE__) = {	\

Added: head/usr.sbin/bhyve/legacy_irq.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.sbin/bhyve/legacy_irq.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -0,0 +1,80 @@
+/*-
+ * Copyright (c) 2013 Neel Natu <neel at freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <stdbool.h>
+#include <assert.h>
+
+/*
+ * Used to keep track of legacy interrupt owners/requestors
+ */
+#define NLIRQ		16
+
+static struct lirqinfo {
+	bool	li_generic;
+	bool	li_allocated;
+} lirq[NLIRQ];
+
+void
+legacy_irq_init(void)
+{
+
+	/*
+	 * Allow ISA IRQs 5,10,11,12, and 15 to be available for generic use.
+	 */
+	lirq[5].li_generic = true;
+	lirq[10].li_generic = true;
+	lirq[11].li_generic = true;
+	lirq[12].li_generic = true;
+	lirq[15].li_generic = true;
+}
+
+int
+legacy_irq_alloc(int irq)
+{
+	int i;
+
+	assert(irq < NLIRQ);
+
+	if (irq < 0) {
+		for (i = 0; i < NLIRQ; i++) {
+			if (lirq[i].li_generic && !lirq[i].li_allocated) {
+				irq = i;
+				break;
+			}
+		}
+	} else {
+		if (lirq[irq].li_allocated)
+			irq = -1;
+	}
+
+	if (irq >= 0) {
+		lirq[irq].li_allocated = true;
+		return (irq);
+	} else
+		return (-1);
+}

Added: head/usr.sbin/bhyve/legacy_irq.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.sbin/bhyve/legacy_irq.h	Tue Oct 29 00:18:11 2013	(r257293)
@@ -0,0 +1,41 @@
+/*-
+ * Copyright (c) 2013 Neel Natu <neel at freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef _LEGACY_IRQ_H_
+#define	_LEGACY_IRQ_H_
+
+/*
+ * Allocate a legacy irq. The argument 'irq' can be set to -1 to allocate any
+ * available irq.
+ *
+ * Returns -1 on failure or the allocated irq number on success.
+ */
+int	legacy_irq_alloc(int irq);
+void	legacy_irq_init(void);
+
+#endif

Modified: head/usr.sbin/bhyve/pci_emul.c
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.c	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/pci_emul.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -46,6 +46,7 @@ __FBSDID("$FreeBSD$");
 
 #include "bhyverun.h"
 #include "inout.h"
+#include "legacy_irq.h"
 #include "mem.h"
 #include "pci_emul.h"
 #include "ioapic.h"
@@ -76,17 +77,6 @@ static struct slotinfo {
 	int	si_legacy;
 } pci_slotinfo[MAXSLOTS][MAXFUNCS];
 
-/*
- * Used to keep track of legacy interrupt owners/requestors
- */
-#define NLIRQ		16
-
-static struct lirqinfo {
-	int	li_generic;
-	int	li_acount;
-	struct pci_devinst *li_owner;	/* XXX should be a list */
-} lirq[NLIRQ];
-
 SET_DECLARE(pci_devemu_set, struct pci_devemu);
 
 static uint64_t pci_emul_iobase;
@@ -682,6 +672,7 @@ pci_emul_init(struct vmctx *ctx, struct 
 	pdi->pi_bus = 0;
 	pdi->pi_slot = slot;
 	pdi->pi_func = func;
+	pdi->pi_lintr_pin = -1;
 	pdi->pi_d = pde;
 	snprintf(pdi->pi_name, PI_NAMESZ, "%s-pci-%d", pde->pe_emu, slot);
 
@@ -1023,16 +1014,6 @@ init_pci(struct vmctx *ctx)
 	pci_emul_membase32 = vm_get_lowmem_limit(ctx);
 	pci_emul_membase64 = PCI_EMUL_MEMBASE64;
 
-	/*
-	 * Allow ISA IRQs 5,10,11,12, and 15 to be available for
-	 * generic use
-	 */
-	lirq[5].li_generic = 1;
-	lirq[10].li_generic = 1;
-	lirq[11].li_generic = 1;
-	lirq[12].li_generic = 1;
-	lirq[15].li_generic = 1;
-
 	for (slot = 0; slot < MAXSLOTS; slot++) {
 		for (func = 0; func < MAXFUNCS; func++) {
 			si = &pci_slotinfo[slot][func];
@@ -1135,40 +1116,17 @@ pci_is_legacy(struct pci_devinst *pi)
 	return (pci_slotinfo[pi->pi_slot][pi->pi_func].si_legacy);
 }
 
-static int
-pci_lintr_alloc(struct pci_devinst *pi, int vec)
-{
-	int i;
-
-	assert(vec < NLIRQ);
-
-	if (vec == -1) {
-		for (i = 0; i < NLIRQ; i++) {
-			if (lirq[i].li_generic &&
-			    lirq[i].li_owner == NULL) {
-				vec = i;
-				break;
-			}
-		}
-	} else {
-		if (lirq[vec].li_owner != NULL) {
-			vec = -1;
-		}
-	}
-	assert(vec != -1);
-
-	lirq[vec].li_owner = pi;
-	pi->pi_lintr_pin = vec;
-
-	return (vec);
-}
-
 int
-pci_lintr_request(struct pci_devinst *pi, int vec)
+pci_lintr_request(struct pci_devinst *pi, int req)
 {
+	int irq;
+
+	irq = legacy_irq_alloc(req);
+	if (irq < 0)
+		return (-1);
 
-	vec = pci_lintr_alloc(pi, vec);
-	pci_set_cfgdata8(pi, PCIR_INTLINE, vec);
+	pi->pi_lintr_pin = irq;
+	pci_set_cfgdata8(pi, PCIR_INTLINE, irq);
 	pci_set_cfgdata8(pi, PCIR_INTPIN, 1);
 	return (0);
 }
@@ -1177,7 +1135,7 @@ void
 pci_lintr_assert(struct pci_devinst *pi)
 {
 
-	assert(pi->pi_lintr_pin);
+	assert(pi->pi_lintr_pin >= 0);
 	ioapic_assert_pin(pi->pi_vmctx, pi->pi_lintr_pin);
 }
 
@@ -1185,7 +1143,7 @@ void
 pci_lintr_deassert(struct pci_devinst *pi)
 {
 
-	assert(pi->pi_lintr_pin);
+	assert(pi->pi_lintr_pin >= 0);
 	ioapic_deassert_pin(pi->pi_vmctx, pi->pi_lintr_pin);
 }
 

Modified: head/usr.sbin/bhyve/pci_emul.h
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.h	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/pci_emul.h	Tue Oct 29 00:18:11 2013	(r257293)
@@ -103,7 +103,7 @@ struct pci_devinst {
 	struct pci_devemu *pi_d;
 	struct vmctx *pi_vmctx;
 	uint8_t	  pi_bus, pi_slot, pi_func;
-	uint8_t   pi_lintr_pin;
+	int8_t    pi_lintr_pin;
 	char	  pi_name[PI_NAMESZ];
 	int	  pi_bar_getsize;
 

Added: head/usr.sbin/bhyve/pci_lpc.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.sbin/bhyve/pci_lpc.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -0,0 +1,214 @@
+/*-
+ * Copyright (c) 2013 Neel Natu <neel at freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <sys/cdefs.h>
+__FBSDID("$FreeBSD$");
+
+#include <sys/types.h>
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "inout.h"
+#include "ioapic.h"
+#include "pci_emul.h"
+#include "uart_emul.h"
+
+static struct pci_devinst *lpc_bridge;
+
+#define	LPC_UART_NUM	2
+static struct lpc_uart_softc {
+	struct uart_softc *uart_softc;
+	const char *opts;
+	int	iobase;
+	int	irq;
+} lpc_uart_softc[LPC_UART_NUM];
+
+static const char *lpc_uart_names[LPC_UART_NUM] = { "COM1", "COM2" };
+
+/*
+ * LPC device configuration is in the following form:
+ * <lpc_device_name>[,<options>]
+ * For e.g. "com1,stdio"
+ */
+int
+lpc_device_parse(const char *opts)
+{
+	int unit, error;
+	char *str, *cpy, *lpcdev;
+
+	error = -1;
+	str = cpy = strdup(opts);
+	lpcdev = strsep(&str, ",");
+	if (lpcdev != NULL) {
+		for (unit = 0; unit < LPC_UART_NUM; unit++) {
+			if (strcasecmp(lpcdev, lpc_uart_names[unit]) == 0) {
+				lpc_uart_softc[unit].opts = str;
+				error = 0;
+				goto done;
+			}
+		}
+	}
+
+done:
+	if (error)
+		free(cpy);
+
+	return (error);
+}
+
+static void
+lpc_uart_intr_assert(void *arg)
+{
+	struct lpc_uart_softc *sc = arg;
+
+	assert(sc->irq >= 0);
+
+	ioapic_assert_pin(lpc_bridge->pi_vmctx, sc->irq);
+}
+
+static void
+lpc_uart_intr_deassert(void *arg)
+{
+	struct lpc_uart_softc *sc = arg;
+
+	assert(sc->irq >= 0);
+
+	ioapic_deassert_pin(lpc_bridge->pi_vmctx, sc->irq);
+}
+
+static int
+lpc_uart_io_handler(struct vmctx *ctx, int vcpu, int in, int port, int bytes,
+		    uint32_t *eax, void *arg)
+{
+	int offset;
+	struct lpc_uart_softc *sc = arg;
+
+	if (bytes != 1)
+		return (-1);
+
+	offset = port - sc->iobase;
+
+	if (in)
+		*eax = uart_read(sc->uart_softc, offset); 
+	else
+		uart_write(sc->uart_softc, offset, *eax);
+
+	return (0);
+}
+
+static int
+lpc_init(void)
+{
+	struct lpc_uart_softc *sc;
+	struct inout_port iop;
+	const char *name;
+	int unit, error;
+
+	/* COM1 and COM2 */
+	for (unit = 0; unit < LPC_UART_NUM; unit++) {
+		sc = &lpc_uart_softc[unit];
+		name = lpc_uart_names[unit];
+
+		if (uart_legacy_alloc(unit, &sc->iobase, &sc->irq) != 0) {
+			fprintf(stderr, "Unable to allocate resources for "
+			    "LPC device %s\n", name);
+			return (-1);
+		}
+
+		sc->uart_softc = uart_init(lpc_uart_intr_assert,
+				    lpc_uart_intr_deassert, sc);
+
+		if (uart_set_backend(sc->uart_softc, sc->opts) != 0) {
+			fprintf(stderr, "Unable to initialize backend '%s' "
+			    "for LPC device %s\n", sc->opts, name);
+			return (-1);
+		}
+
+		bzero(&iop, sizeof(struct inout_port));
+		iop.name = name;
+		iop.port = sc->iobase;
+		iop.size = UART_IO_BAR_SIZE;
+		iop.flags = IOPORT_F_INOUT;
+		iop.handler = lpc_uart_io_handler;
+		iop.arg = sc;
+
+		error = register_inout(&iop);
+		assert(error == 0);
+	}
+
+	return (0);
+}
+
+static void
+pci_lpc_write(struct vmctx *ctx, int vcpu, struct pci_devinst *pi,
+	       int baridx, uint64_t offset, int size, uint64_t value)
+{
+}
+
+uint64_t
+pci_lpc_read(struct vmctx *ctx, int vcpu, struct pci_devinst *pi,
+	      int baridx, uint64_t offset, int size)
+{
+	return (0);
+}
+
+#define	LPC_DEV		0x7000
+#define	LPC_VENDOR	0x8086
+
+static int
+pci_lpc_init(struct vmctx *ctx, struct pci_devinst *pi, char *opts)
+{
+	/*
+	 * Do not allow more than one LPC bridge to be configured.
+	 */
+	if (lpc_bridge != NULL)
+		return (-1);
+
+	if (lpc_init() != 0)
+		return (-1);
+
+	/* initialize config space */
+	pci_set_cfgdata16(pi, PCIR_DEVICE, LPC_DEV);
+	pci_set_cfgdata16(pi, PCIR_VENDOR, LPC_VENDOR);
+	pci_set_cfgdata8(pi, PCIR_CLASS, PCIC_BRIDGE);
+	pci_set_cfgdata8(pi, PCIR_SUBCLASS, PCIS_BRIDGE_ISA);
+
+	lpc_bridge = pi;
+
+	return (0);
+}
+
+struct pci_devemu pci_de_lpc = {
+	.pe_emu =	"lpc",
+	.pe_init =	pci_lpc_init,
+	.pe_barwrite =	pci_lpc_write,
+	.pe_barread =	pci_lpc_read
+};
+PCI_EMUL_SET(pci_de_lpc);

Added: head/usr.sbin/bhyve/pci_lpc.h
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/usr.sbin/bhyve/pci_lpc.h	Tue Oct 29 00:18:11 2013	(r257293)
@@ -0,0 +1,34 @@
+/*-
+ * Copyright (c) 2013 Neel Natu <neel at freebsd.org>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef _LPC_H_
+#define	_LPC_H_
+
+int	lpc_device_parse(const char *opt);
+
+#endif

Modified: head/usr.sbin/bhyve/pci_uart.c
==============================================================================
--- head/usr.sbin/bhyve/pci_uart.c	Mon Oct 28 23:47:52 2013	(r257292)
+++ head/usr.sbin/bhyve/pci_uart.c	Tue Oct 29 00:18:11 2013	(r257293)
@@ -30,42 +30,12 @@
 __FBSDID("$FreeBSD$");
 
 #include <sys/types.h>
-#include <sys/select.h>
-#include <dev/ic/ns16550.h>
 
 #include <stdio.h>
-#include <stdlib.h>
-#include <assert.h>
-#include <termios.h>
-#include <unistd.h>
-#include <stdbool.h>
-#include <string.h>
-#include <pthread.h>
 
 #include "bhyverun.h"
 #include "pci_emul.h"
-#include "mevent.h"
-
-#define	COM1_BASE      	0x3F8
-#define COM1_IRQ	4
-#define	COM2_BASE      	0x2F8
-#define COM2_IRQ	3
-
-#define	DEFAULT_RCLK	1843200
-#define	DEFAULT_BAUD	9600
-
-#define	FCR_RX_MASK	0xC0
-
-#define	MCR_OUT1	0x04
-#define	MCR_OUT2	0x08
-
-#define	MSR_DELTA_MASK	0x0f
-
-#ifndef REG_SCR
-#define REG_SCR		com_scr
-#endif
-
-#define	FIFOSZ	16
+#include "uart_emul.h"
 
 /*
  * Pick a PCI vid/did of a chip with a single uart at
@@ -75,544 +45,82 @@ __FBSDID("$FreeBSD$");
 #define COM_VENDOR	0x131f
 #define COM_DEV		0x2000
 
-static int pci_uart_stdio;	/* stdio in use for i/o */
-
-static int pci_uart_nldevs;	/* number of legacy devices - 2 max */
-
-static struct {
-	uint64_t	baddr;
-	int		vector;
-} pci_uart_lres[] = {
-	{ COM1_BASE, COM1_IRQ},
-	{ COM2_BASE, COM2_IRQ},
-	{ 0, 0 }
-};
-
-struct fifo {
-	uint8_t	buf[FIFOSZ];
-	int	rindex;		/* index to read from */
-	int	windex;		/* index to write to */
-	int	num;		/* number of characters in the fifo */
-	int	size;		/* size of the fifo */
-};
-
-struct pci_uart_softc {
-	struct pci_devinst *pi;
-	pthread_mutex_t mtx;	/* protects all softc elements */
-	uint8_t data;		/* Data register (R/W) */
-	uint8_t ier;		/* Interrupt enable register (R/W) */
-	uint8_t lcr;		/* Line control register (R/W) */
-	uint8_t mcr;		/* Modem control register (R/W) */
-	uint8_t lsr;		/* Line status register (R/W) */
-	uint8_t msr;		/* Modem status register (R/W) */
-	uint8_t fcr;		/* FIFO control register (W) */
-	uint8_t scr;		/* Scratch register (R/W) */
-
-	uint8_t dll;		/* Baudrate divisor latch LSB */
-	uint8_t dlh;		/* Baudrate divisor latch MSB */
-
-	struct fifo rxfifo;
-
-	int	opened;
-	int	stdio;
-	bool	thre_int_pending;	/* THRE interrupt pending */
-};
-
-static void pci_uart_drain(int fd, enum ev_type ev, void *arg);
-
-static struct termios tio_orig, tio_new;	/* I/O Terminals */
-
-static void
-ttyclose(void)
-{
-	tcsetattr(STDIN_FILENO, TCSANOW, &tio_orig);
-}
-
-static void
-ttyopen(void)
-{
-	tcgetattr(STDIN_FILENO, &tio_orig);
-
-	cfmakeraw(&tio_new);
-	tcsetattr(STDIN_FILENO, TCSANOW, &tio_new);
-
-	atexit(ttyclose);
-}
-
-static bool
-tty_char_available(void)
-{
-	fd_set rfds;
-	struct timeval tv;
-
-	FD_ZERO(&rfds);
-	FD_SET(STDIN_FILENO, &rfds);
-	tv.tv_sec = 0;
-	tv.tv_usec = 0;
-	if (select(STDIN_FILENO + 1, &rfds, NULL, NULL, &tv) > 0 ) {
-		return (true);
-	} else {
-		return (false);
-	}
-}
-
-static int
-ttyread(void)
-{
-	char rb;
-
-	if (tty_char_available()) {
-		read(STDIN_FILENO, &rb, 1);
-		return (rb & 0xff);
-	} else {
-		return (-1);
-	}
-}
-
-static void
-ttywrite(unsigned char wb)
-{
-	(void) write(STDIN_FILENO, &wb, 1);
-}
-
-static void
-fifo_reset(struct fifo *fifo, int size)
-{
-	bzero(fifo, sizeof(struct fifo));
-	fifo->size = size;
-}
-
-static int
-fifo_putchar(struct fifo *fifo, uint8_t ch)
-{
-
-	if (fifo->num < fifo->size) {
-		fifo->buf[fifo->windex] = ch;
-		fifo->windex = (fifo->windex + 1) % fifo->size;
-		fifo->num++;
-		return (0);
-	} else
-		return (-1);
-}
-
-static int
-fifo_getchar(struct fifo *fifo)
-{
-	int c;
-
-	if (fifo->num > 0) {
-		c = fifo->buf[fifo->rindex];
-		fifo->rindex = (fifo->rindex + 1) % fifo->size;
-		fifo->num--;
-		return (c);
-	} else
-		return (-1);
-}
-
-static int
-fifo_numchars(struct fifo *fifo)
-{
-
-	return (fifo->num);
-}
-
-static int
-fifo_available(struct fifo *fifo)
-{
-
-	return (fifo->num < fifo->size);
-}
-
-static void
-pci_uart_opentty(struct pci_uart_softc *sc)
-{
-	struct mevent *mev;
-
-	assert(sc->opened == 0);
-	assert(sc->stdio);
-
-	ttyopen();
-	mev = mevent_add(STDIN_FILENO, EVF_READ, pci_uart_drain, sc);
-	assert(mev);
-}
-
 static void
-pci_uart_legacy_res(uint64_t *bar, int *ivec)
+pci_uart_intr_assert(void *arg)
 {
-	if (pci_uart_lres[pci_uart_nldevs].baddr != 0) {
-		*bar = pci_uart_lres[pci_uart_nldevs].baddr;
-		*ivec = pci_uart_lres[pci_uart_nldevs].vector;
-		pci_uart_nldevs++;
-	} else {
-		/* TODO: print warning ? */
-		*bar = 0;
-		*ivec= -1;
-	}
-}
+	struct pci_devinst *pi = arg;
 
-/*
- * The IIR returns a prioritized interrupt reason:
- * - receive data available
- * - transmit holding register empty
- * - modem status change
- *
- * Return an interrupt reason if one is available.
- */
-static int
-pci_uart_intr_reason(struct pci_uart_softc *sc)
-{
-
-	if ((sc->lsr & LSR_OE) != 0 && (sc->ier & IER_ERLS) != 0)
-		return (IIR_RLS);
-	else if (fifo_numchars(&sc->rxfifo) > 0 && (sc->ier & IER_ERXRDY) != 0)
-		return (IIR_RXTOUT);
-	else if (sc->thre_int_pending && (sc->ier & IER_ETXRDY) != 0)
-		return (IIR_TXRDY);
-	else if ((sc->msr & MSR_DELTA_MASK) != 0 && (sc->ier & IER_EMSC) != 0)
-		return (IIR_MLSC);
-	else
-		return (IIR_NOPEND);
+	pci_lintr_assert(pi);
 }
 
 static void
-pci_uart_reset(struct pci_uart_softc *sc)
+pci_uart_intr_deassert(void *arg)
 {
-	uint16_t divisor;
+	struct pci_devinst *pi = arg;
 
-	divisor = DEFAULT_RCLK / DEFAULT_BAUD / 16;
-	sc->dll = divisor;
-	sc->dlh = divisor >> 16;
-
-	fifo_reset(&sc->rxfifo, 1);	/* no fifo until enabled by software */
-}
-
-/*
- * Toggle the COM port's intr pin depending on whether or not we have an
- * interrupt condition to report to the processor.
- */
-static void
-pci_uart_toggle_intr(struct pci_uart_softc *sc)
-{
-	uint8_t intr_reason;
-
-	intr_reason = pci_uart_intr_reason(sc);
-
-	if (intr_reason == IIR_NOPEND)
-		pci_lintr_deassert(sc->pi);
-	else
-		pci_lintr_assert(sc->pi);
-}
-
-static void
-pci_uart_drain(int fd, enum ev_type ev, void *arg)
-{
-	struct pci_uart_softc *sc;
-	int ch;
-
-	sc = arg;	
-
-	assert(fd == STDIN_FILENO);
-	assert(ev == EVF_READ);
-	
-	/*
-	 * This routine is called in the context of the mevent thread
-	 * to take out the softc lock to protect against concurrent
-	 * access from a vCPU i/o exit
-	 */
-	pthread_mutex_lock(&sc->mtx);
-
-	if ((sc->mcr & MCR_LOOPBACK) != 0) {
-		(void) ttyread();
-	} else {
-		while (fifo_available(&sc->rxfifo) &&
-		       ((ch = ttyread()) != -1)) {
-			fifo_putchar(&sc->rxfifo, ch);
-		}
-		pci_uart_toggle_intr(sc);
-	}
-
-	pthread_mutex_unlock(&sc->mtx);
+	pci_lintr_deassert(pi);
 }
 
 static void
 pci_uart_write(struct vmctx *ctx, int vcpu, struct pci_devinst *pi,
 	       int baridx, uint64_t offset, int size, uint64_t value)
 {
-        struct pci_uart_softc *sc;
-	int fifosz;
-	uint8_t msr;
-
-	sc = pi->pi_arg;
 
 	assert(baridx == 0);
 	assert(size == 1);
 
-	/* Open terminal */
-	if (!sc->opened && sc->stdio) {
-		pci_uart_opentty(sc);
-		sc->opened = 1;
-	}
-
-	pthread_mutex_lock(&sc->mtx);
-	

*** DIFF OUTPUT TRUNCATED AT 1000 LINES ***


More information about the svn-src-all mailing list