svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts

[Teske, Devin]

On Oct 12, 2013, at 8:03 AM, Dag-Erling Smørgrav wrote:

> "Teske, Devin" <Devin.Teske at fisglobal.com> writes:
>> The code to replace the use of camcontrol is a a *very* complex parsing
>> of the geom XML configuration data stashed in sysctl. jmg@ started the
>> ball rolling on that.
> 
> You realize there is a text version as well?
> 
>> Yes. Which has been discussed at-length, you didn't need to put a
>> sandbag on my back (publicly no less; thanks for that).
> 
> Umm, I think Nathan was pretty civil.  You're the one who's turning this
> into a catfight.
> 

Reflecting upon the thread to see if you're _right_...

1. He stated there were still some issues. [definitely civil]
2. "I am surprised you committed it especially to stable/10,
before those issues were resolved." [civil? or inflammatory?]
3. "I'm also not sure if people can review their own patches." [misunderstanding]
4. "Installer regressions are very easy to introduce and very problematic
when created." [statements like that invariably lead people to believe he views
the commit as a regression -- I explained in a follow-up that it is not a regression]
5. "Real review for installer changes is thus especially important this late in the
release cycle." [I read this invariably as he views that the commit did not go
through "Real review", but again... there is no regression and it's purely value-
add]
6. "Do you have any plans to fix these issues in the very near future?" [definitely civil]

What got me ralled up was #'s 2, 4, and 5.
-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.