svn commit: r258310 - head/release

[Glen Barber]

On Tue, Nov 19, 2013 at 03:48:52AM +0900, Hiroki Sato wrote:
> gj> +dvd:
> gj> +# Install system
> gj> +	mkdir -p ${.TARGET}
> gj> +	cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \
> gj> +		DESTDIR=${.OBJDIR}/${.TARGET} WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \
> gj> +		WITHOUT_PROFILE=1
> 
>  Please remove WITHOUT_PROFILE=1 here.
> 

Ok.

> gj> -export PKG_ABI="freebsd:$(echo ${REVISION} | tr -d '.0'):x86:64"
> gj> +export PKG_ABI="freebsd:$(echo ${REVISION} | sed -e 's/\.[0-9]//'):x86:64"
> 
>  PKG_ABI=freebsd:${REVISION%.[0-9]*}:x86:64 is simpler than invoking
>  tr or sed.  However, pkg-stage.sh should have a mapping rule from
>  TARGET and TARGET_ARCH, not in arch specific config files, I think.
>  Other than the package list, variables are not arch-specific.
> 

The pkg(8) ABI does not map directly to anything we use ('amd64' or
'i386') unfortunately.

>  Does this guarantee that the packages downloaded by pkg(8) are for a
>  specific release?  And I think fetching packages can be done just
>  after svn co stage in release.sh.  Collecting up necessity of network
>  access (including fetching distfiles for docproj) before entering the
>  chroot environment makes redoing the release build easier.
> 

I don't think it has been discussed yet where packages built for
a specific release will exist.  Anyway, I would like to avoid directory
hierarchy pollution outside of the dvd/ directory, this is why I use it
for PKG_CACHEDIR directly.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20131118/0ead1409/attachment.sig>