svn commit: r258242 - stable/10/sys/ofed/drivers/net/mlx4

Alfred Perlstein alfred at FreeBSD.org
Sun Nov 17 01:07:47 UTC 2013


Author: alfred
Date: Sun Nov 17 01:07:46 2013
New Revision: 258242
URL: http://svnweb.freebsd.org/changeset/base/258242

Log:
  MFC: 257542
  
  Fix API mismatch exposed by lagg.
  
  When destroying a lagg the driver tries to restore the old mac and
  fails due to API mismatch.
  
  Submitted by:   Shahar Klein (shahark at mellanox.com)
  Approved by:     re

Modified:
  stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c
Directory Properties:
  stable/10/sys/   (props changed)

Modified: stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c
==============================================================================
--- stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 00:49:55 2013	(r258241)
+++ stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 01:07:46 2013	(r258242)
@@ -604,8 +604,8 @@ int mlx4_en_start_port(struct net_device
 	en_dbg(DRV, priv, "Setting mac for port %d\n", priv->port);
 	err = mlx4_register_mac(mdev->dev, priv->port,
 				mlx4_en_mac_to_u64(IF_LLADDR(dev)));
-	if (err) {
-		en_err(priv, "Failed setting port mac\n");
+	if (err < 0) {
+		en_err(priv, "Failed setting port mac err=%d\n", err);
 		goto tx_err;
 	}
 	mdev->mac_removed[priv->port] = 0;


More information about the svn-src-all mailing list