svn commit: r258020 - head/usr.sbin/pkg

Bryan Drewery bdrewery at FreeBSD.org
Mon Nov 11 21:42:32 UTC 2013


Author: bdrewery (ports committer)
Date: Mon Nov 11 21:42:31 2013
New Revision: 258020
URL: http://svnweb.freebsd.org/changeset/base/258020

Log:
  Remove useless checks for NULL pointer before free(3)
  
  Reported by:		eadler
  Approved by:		eadler

Modified:
  head/usr.sbin/pkg/pkg.c

Modified: head/usr.sbin/pkg/pkg.c
==============================================================================
--- head/usr.sbin/pkg/pkg.c	Mon Nov 11 21:27:57 2013	(r258019)
+++ head/usr.sbin/pkg/pkg.c	Mon Nov 11 21:42:31 2013	(r258020)
@@ -326,8 +326,7 @@ free_fingerprint_list(struct fingerprint
 	struct fingerprint *fingerprint, *tmp;
 
 	STAILQ_FOREACH_SAFE(fingerprint, list, next, tmp) {
-		if (fingerprint->name)
-			free(fingerprint->name);
+		free(fingerprint->name);
 		free(fingerprint);
 	}
 	free(list);
@@ -729,12 +728,9 @@ cleanup:
 	if (revoked)
 		free_fingerprint_list(revoked);
 	if (sc) {
-		if (sc->cert)
-			free(sc->cert);
-		if (sc->sig)
-			free(sc->sig);
-		if (sc->name)
-			free(sc->name);
+		free(sc->cert);
+		free(sc->sig);
+		free(sc->name);
 		free(sc);
 	}
 


More information about the svn-src-all mailing list