this breaks builds of head on stable/9 (Re: svn commit: r257268 - head/gnu/usr.bin/binutils/ld

[Brooks Davis]

On Thu, Oct 31, 2013 at 06:02:25PM -0700, Luigi Rizzo wrote:
> as per the subject, after this commit building head on stable/9
> fails with the error below:
> 
> ===> lib/libpam/modules/pam_krb5 (all)
> make: don't know how to make
> /media/bsd10/usr/home/luigi/FreeBSD/head/../usr/obj-pico-amd64/media/bsd10/usr/home/luigi/FreeBSD/head/tmp/usr/lib/libkrb5.a.
> Stop
> 
> reverting the commit fixes the build.
> 
> Any idea how this can be fixed ?

I just built world and kernel with a freshly checked out head on
ref9-amd64 so I supect something in your environment.  This change
should only impact the installed copy of ld which would have no effect
on a 9-stable system.  Any portion of the build system using a version
effected by this change is broken since only the cross build version
should be used and that one will have it's own sysroot value as always
it always has.

-- Brooks

> On Mon, Oct 28, 2013 at 12:56 PM, Brooks Davis <brooks at freebsd.org> wrote:
> 
> > Author: brooks
> > Date: Mon Oct 28 19:56:46 2013
> > New Revision: 257268
> > URL: http://svnweb.freebsd.org/changeset/base/257268
> >
> > Log:
> >   Enable the --sysroot=/foo option in ld by always building with a sysroot
> >   defined. When not building as a cross linker, the sysroot is set to "/".
> >
> >   Exp-run by:   bdrewery (ports/183206)
> >   MFC after:    3 days
> >
> > Modified:
> >   head/gnu/usr.bin/binutils/ld/Makefile
> >
> > Modified: head/gnu/usr.bin/binutils/ld/Makefile
> >
> > ==============================================================================
> > --- head/gnu/usr.bin/binutils/ld/Makefile       Mon Oct 28 19:46:01 2013
> >      (r257267)
> > +++ head/gnu/usr.bin/binutils/ld/Makefile       Mon Oct 28 19:56:46 2013
> >      (r257268)
> > @@ -31,7 +31,7 @@ CFLAGS+= -DTARGET=\"${TARGET_TUPLE}\"
> >  CFLAGS+= -DDEFAULT_EMULATION=\"${NATIVE_EMULATION}\"
> >  CFLAGS+= -DSCRIPTDIR=\"${TOOLS_PREFIX}/usr/libdata\"
> >  CFLAGS+= -DBFD_VERSION_STRING=\"${VERSION}\"
> > -CFLAGS+= -DBINDIR=\"${BINDIR}\" -DTARGET_SYSTEM_ROOT=\"${TOOLS_PREFIX}\"
> > +CFLAGS+= -DBINDIR=\"${BINDIR}\"
> > -DTARGET_SYSTEM_ROOT=\"${TOOLS_PREFIX:U/}\"
> >  CFLAGS+= -DTOOLBINDIR=\"${TOOLS_PREFIX}/${BINDIR}/libexec\"
> >  CFLAGS+= -D_GNU_SOURCE
> >  CFLAGS+= -I${SRCDIR}/ld -I${SRCDIR}/bfd
> >
> 
> 
> 
> -- 
> -----------------------------------------+-------------------------------
>  Prof. Luigi RIZZO, rizzo at iet.unipi.it  . Dip. di Ing. dell'Informazione
>  http://www.iet.unipi.it/~luigi/        . Universita` di Pisa
>  TEL      +39-050-2211611               . via Diotisalvi 2
>  Mobile   +39-338-6809875               . 56122 PISA (Italy)
> -----------------------------------------+-------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20131031/f79d6056/attachment.sig>