svn commit: r251186 - head/usr.sbin/acpi/acpidump

Jung-uk Kim jkim at FreeBSD.org
Fri May 31 17:23:39 UTC 2013


Author: jkim
Date: Fri May 31 17:23:38 2013
New Revision: 251186
URL: http://svnweb.freebsd.org/changeset/base/251186

Log:
  Fix a long standing logic bug introduced in r167814.  The code was added to
  get RSDP from loader(8) hint via kenv(2) but the bug nullified the new code
  and we always fell back to the previous method, i. e., sysctlbyname(3).
  
  MFC after:	3 days

Modified:
  head/usr.sbin/acpi/acpidump/acpi_user.c

Modified: head/usr.sbin/acpi/acpidump/acpi_user.c
==============================================================================
--- head/usr.sbin/acpi/acpidump/acpi_user.c	Fri May 31 17:01:53 2013	(r251185)
+++ head/usr.sbin/acpi/acpidump/acpi_user.c	Fri May 31 17:23:38 2013	(r251186)
@@ -172,7 +172,7 @@ acpi_find_rsd_ptr(void)
 	addr = 0;
 
 	/* Attempt to use kenv or sysctl to find RSD PTR record. */
-	if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) == 0)
+	if (kenv(KENV_GET, hint_acpi_0_rsdp, buf, 20) > 0)
 		addr = strtoul(buf, NULL, 0);
 	if (addr == 0) {
 		len = sizeof(addr);


More information about the svn-src-all mailing list