svn commit: r251098 - head/sys/contrib/dev/ath/ath_hal/ar9300

[Adrian Chadd]

No, it actually failed to compile at all on some older 9-stable laptops..

Hence my confusion.


Adrian

On 29 May 2013 04:22, Dimitry Andric <dim at freebsd.org> wrote:
> On 2013-05-29 06:21, Adrian Chadd wrote:
>>
>> Author: adrian
>> Date: Wed May 29 04:21:42 2013
>> New Revision: 251098
>> URL: http://svnweb.freebsd.org/changeset/base/251098
>>
>> Log:
>>    Fix a false -> AH_FALSE.
>>
>>    Now, why this hasn't tripped _any_ tinderbox builds yet, I dunno.
>>    It's been like this for a while.
>
>
> Because 'false' will be implicitly converted to an enum HAL_BOOL value.
> Adding a warning for such cases would result in a *lot* of noise, and
> probably many angry developers. ;-)
>
> Note that in C++, such a call would result in an error: "no known
> conversion from 'bool' to 'HAL_BOOL'".
>