svn commit: r250972 - head/usr.bin/patch

Pawel Jakub Dawidek pjd at FreeBSD.org
Sun May 26 21:48:41 UTC 2013


On Sat, May 25, 2013 at 01:11:27AM -0400, Glen Barber wrote:
> On Fri, May 24, 2013 at 06:54:52PM +0000, Stefan Esser wrote:
> > Author: se
> > Date: Fri May 24 18:54:52 2013
> > New Revision: 250972
> > URL: http://svnweb.freebsd.org/changeset/base/250972
> > 
> 
> > [...]
> 
> > @@ -977,7 +977,7 @@ spew_output(void)
> >  #endif
> >  	if (input_lines)
> >  		copy_till(input_lines, true);	/* dump remainder of file */
> > -	rv = ferror(ofp) == 0 && fclose(ofp) == 0;
> > +	rv = ferror(ofp) == 0 & fclose(ofp) == 0;
> >  	ofp = NULL;
> >  	return rv;
> >  }
> > 
> 
> This breaks head/.

Not to mention that it is really ugly and without any comment it looks
like a typo.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://mobter.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20130526/b6f1af61/attachment.sig>


More information about the svn-src-all mailing list