svn commit: r250892 - head/sys/ufs/ffs
Kirk McKusick
mckusick at FreeBSD.org
Wed May 22 00:30:35 UTC 2013
Author: mckusick
Date: Wed May 22 00:30:34 2013
New Revision: 250892
URL: http://svnweb.freebsd.org/changeset/base/250892
Log:
Remove a bogus check for a NULL buffer pointer.
Add a KASSERT that it is not NULL.
Found by: Coverity Scan, CID 1009114
Reviewed by: kib
MFC after: 2 weeks
Modified:
head/sys/ufs/ffs/ffs_softdep.c
Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.c Wed May 22 00:17:50 2013 (r250891)
+++ head/sys/ufs/ffs/ffs_softdep.c Wed May 22 00:30:34 2013 (r250892)
@@ -4984,13 +4984,14 @@ bmsafemap_lookup(mp, bp, cg, newbmsafema
struct fs *fs;
mtx_assert(&lk, MA_OWNED);
- if (bp)
- LIST_FOREACH(wk, &bp->b_dep, wk_list)
- if (wk->wk_type == D_BMSAFEMAP) {
- if (newbmsafemap)
- WORKITEM_FREE(newbmsafemap,D_BMSAFEMAP);
- return (WK_BMSAFEMAP(wk));
- }
+ KASSERT(bp != NULL, ("bmsafemap_lookup: missing buffer"));
+ LIST_FOREACH(wk, &bp->b_dep, wk_list) {
+ if (wk->wk_type == D_BMSAFEMAP) {
+ if (newbmsafemap)
+ WORKITEM_FREE(newbmsafemap, D_BMSAFEMAP);
+ return (WK_BMSAFEMAP(wk));
+ }
+ }
fs = VFSTOUFS(mp)->um_fs;
bmsafemaphd = BMSAFEMAP_HASH(fs, cg);
if (bmsafemap_find(bmsafemaphd, mp, cg, &bmsafemap) == 1) {
More information about the svn-src-all
mailing list