svn commit: r250193 - head/sys/fs/msdosfs

John Baldwin jhb at freebsd.org
Fri May 3 20:54:54 UTC 2013


On Friday, May 03, 2013 4:35:41 pm Konstantin Belousov wrote:
> On Fri, May 03, 2013 at 11:55:47AM -0400, John Baldwin wrote:
> > On Thursday, May 02, 2013 4:00:11 pm Konstantin Belousov wrote:
> > > Author: kib
> > > Date: Thu May  2 20:00:11 2013
> > > New Revision: 250193
> > > URL: http://svnweb.freebsd.org/changeset/base/250193
> > > 
> > > Log:
> > >   The fsync(2) call should sync the vnode in such way that even after
> > >   system crash which happen after successfull fsync() return, the data
> > >   is accessible.  For msdosfs, this means that FAT entries for the file
> > >   must be written.
> > >   
> > >   Since we do not track the FAT blocks containing entries for the
> > >   current file, just do a sloppy sync of the devvp vnode for the mount,
> > >   which buffers, among other things, contain FAT blocks.
> ...
> 
> > Does this fix kern/62762?
> > 
> 
> Supposedly yes, I even possibly have seen this PR before.
> At least, it is understandable why do you remember about it now.
> 
> I definitely do not want to take the approach of precisely calculating
> the list of FAT blocks which needs to be synced.

No, that seems too painful.

-- 
John Baldwin


More information about the svn-src-all mailing list