svn commit: r247814 - in head: . sys/amd64/conf sys/cam/ctl sys/conf sys/i386/conf

[John Baldwin]

On Saturday, March 16, 2013 12:54:01 pm Rui Paulo wrote:
> On 2013/03/13, at 8:08, John Baldwin <jhb at freebsd.org> wrote:
> 
> > On Tuesday, March 12, 2013 5:09:21 pm Pawel Jakub Dawidek wrote:
> >> On Mon, Mar 04, 2013 at 09:18:45PM +0000, Kenneth D. Merry wrote:
> >>> Author: ken
> >>> Date: Mon Mar  4 21:18:45 2013
> >>> New Revision: 247814
> >>> URL: http://svnweb.freebsd.org/changeset/base/247814
> >>> 
> >>> Log:
> >>>  Re-enable CTL in GENERIC on i386 and amd64, but turn on the CTL disable
> >>>  tunable by default.
> >>> 
> >>>  This will allow GENERIC configurations to boot on small memory boxes, but
> >>>  not require end users who want to use CTL to recompile their kernel.  They
> >>>  can simply set kern.cam.ctl.disable=0 in loader.conf.
> >> 
> >> Could you rename it to kern.cam.ctl.enable(d)? There was discussion at
> >> some point about sysctl/tunable names and the consensus was, AFAIR, to
> >> use positive(?) names as they are more obvious.
> > 
> > Except that all the hints we use for devices are hint.foo.X.disable=1 :)
> 
> 
> I think this is not correct. The `disabled' hint comes from
> resource_disabled(), which checks for
> "resource_int_value(name, unit, "disabled", &value);"

Yes, it probably is disabled rather than disable, but the point about it being
a negative "disable" hint vs a positive "enable" hint still stands.

-- 
John Baldwin