svn commit: r246856 - head/etc

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-03-06 10:01:33 -0500, Gleb Smirnoff wrote:
> Jung-uk,
> 
> On Fri, Feb 15, 2013 at 10:58:44PM +0000, Jung-uk Kim wrote: J>
> Author: jkim J> Date: Fri Feb 15 22:58:44 2013 J> New Revision:
> 246856 J> URL: http://svnweb.freebsd.org/changeset/base/246856 J> 
> J> Log: J>   Revert r227528 and r227787.  This hack is no longer
> necessary since r233580.
> 
> I'm sorry, but it doesn't work. Mouse isn't working after resume
> for me on r247873.
> 
> Please return the code back, and I'd appreciate if next time you 
> back something out, you communicate with the person who added the 
> code to give him a chance to confirm or decline whether code is
> still needed or not.
> 
> Thanks.
> 
> J> Modified: J>   head/etc/rc.resume J> J> Modified:
> head/etc/rc.resume J>
> ==============================================================================
>
> 
J> --- head/etc/rc.resume	Fri Feb 15 22:43:08 2013	(r246855)
> J> +++ head/etc/rc.resume	Fri Feb 15 22:58:44 2013	(r246856) J> @@
> -43,10 +43,6 @@ if [ -r /var/run/rc.suspend.pid ]; then J>  	echo
> 'rc.resume: killed rc.suspend that was still around' J>  fi J> J>
> -if [ -r /var/run/moused.pid ]; then J> -	pkill -HUP -F
> /var/run/moused.pid J> -fi J> - J>  # Turns on a power supply of a
> card in the slot inactivated. J>  # See also contrib/pccardq.c
> (only for PAO users). J>  # pccardq | awk -F '~' '$5 == "inactive"
> \
> 

You know, I disagreed with the above change because this type of
quirks can be easily handled by the driver.  IMHO, /etc/rc.resume is
the last place to put it.  When I committed r233580 to fix resuming
psm(4) and MFC'd it to stable/9 (r234713), we had an agreement to back
it out if we hear no user complaints for enough time *without* merging
your /etc/rc.resume changes.  At least, that's what I remember.  In
fact, you never MFC'd your changes.  So, I thought the agreement is
still valid and it is safe to back out.  I am sorry for not asking
your confirmation, though.

Now, please consider fixing psm.  If you can't find a generic
solution, it is okay to add your model-specific quirk in
sys/dev/atkbdc/psm.c like this:

http://svnweb.freebsd.org/base/head/sys/dev/atkbdc/psm.c?annotate=233580#l1441

Also, please mention it in the manual page, i.e., the CAVEATS section of
psm(4).

Thanks,

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJRN44uAAoJECXpabHZMqHO1loH/3/lBVpM/mo+VhOJmK3u2qqk
/8o7Lxyv6sLZ0Og9hCoyi1EKVFUAxuPoVWeyeydPFSs2NcbJZvP9E80T4ompCGX9
m6wOs3SqI1LBNwIpWWa7O6M0rGhkP4Y0uFUe7MLN5/8FW1OEEChcboo11iq2Ftex
mzaElMFjefXbw3DDyknqZNyBbEWkSsPyhuMN1TpLXR0VVSM8/dzUsxwbYk1rrWrf
TY4U9wzvJz0rgMkjAhB8SPJl/JO7NLQGMlnhLNzIR7EMbtO2EZ5OLxNFJsqZ4pjf
XbRDFrtGT3N90UIKhpivBSG9+929hAwS+y29wn3xn5B8aUdmfcgT5mHH8LXY7DI=
=KcJ+
-----END PGP SIGNATURE-----