svn commit: r251490 - head/sys/net

Gleb Smirnoff glebius at FreeBSD.org
Fri Jun 7 10:33:55 UTC 2013


On Fri, Jun 07, 2013 at 02:33:08PM +0400, Gleb Smirnoff wrote:
T> On Fri, Jun 07, 2013 at 10:27:51AM +0000, Mikolaj Golub wrote:
T> M> Author: trociny
T> M> Date: Fri Jun  7 10:27:50 2013
T> M> New Revision: 251490
T> M> URL: http://svnweb.freebsd.org/changeset/base/251490
T> M> 
T> M> Log:
T> M>   Properly set curvnet context in lagg_port_setlladdr() task handler.
T> M>   
T> M>   Reported by:	Nikos Vassiliadis <nvass gmx.com>
T> M>   Submitted by:	zec
T> M>   Tested by:	Nikos Vassiliadis <nvass gmx.com>
T> M>   MFC after:	1 week
T> M> 
T> M> Modified:
T> M>   head/sys/net/if_lagg.c
T> M> 
T> M> Modified: head/sys/net/if_lagg.c
T> M> ==============================================================================
T> M> --- head/sys/net/if_lagg.c	Fri Jun  7 09:06:50 2013	(r251489)
T> M> +++ head/sys/net/if_lagg.c	Fri Jun  7 10:27:50 2013	(r251490)
T> M> @@ -505,7 +505,9 @@ lagg_port_setlladdr(void *arg, int pendi
T> M>  		ifp = llq->llq_ifp;
T> M>  
T> M>  		/* Set the link layer address */
T> M> +		CURVNET_SET(ifp->if_vnet);
T> M>  		error = if_setlladdr(ifp, llq->llq_lladdr, ETHER_ADDR_LEN);
T> M> +		CURVNET_RESTORE();
T> M>  		if (error)
T> M>  			printf("%s: setlladdr failed on %s\n", __func__,
T> M>  			    ifp->if_xname);
T> 
T> IMHO, the entire task function should be embraced into VNET context.

Sorry, I'm wrong. :(

-- 
Totus tuus, Glebius.


More information about the svn-src-all mailing list