svn commit: r251253 - head/sys/dev/usb/controller

[Hans Petter Selasky]

Author: hselasky
Date: Sun Jun  2 12:16:58 2013
New Revision: 251253
URL: http://svnweb.freebsd.org/changeset/base/251253

Log:
  Correct TRB type for multi TRB transfers of non-NORMAL type, like isochronous.
  Only the first TRB should be markes as special. Subsequent ones should be
  marked as NORMAL. Optimise away TD first variable.
  
  MFC after:	1 week

Modified:
  head/sys/dev/usb/controller/xhci.c

Modified: head/sys/dev/usb/controller/xhci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci.c	Sun Jun  2 12:00:16 2013	(r251252)
+++ head/sys/dev/usb/controller/xhci.c	Sun Jun  2 12:16:58 2013	(r251253)
@@ -1545,7 +1545,6 @@ xhci_setup_generic_chain_sub(struct xhci
 {
 	struct usb_page_search buf_res;
 	struct xhci_td *td;
-	struct xhci_td *td_first;
 	struct xhci_td *td_next;
 	struct xhci_td *td_alt_next;
 	uint32_t buf_offset;
@@ -1555,6 +1554,7 @@ xhci_setup_generic_chain_sub(struct xhci
 	uint8_t shortpkt_old;
 	uint8_t precompute;
 	uint8_t x;
+	uint8_t first_trb = 1;
 
 	td_alt_next = NULL;
 	buf_offset = 0;
@@ -1565,7 +1565,7 @@ xhci_setup_generic_chain_sub(struct xhci
 restart:
 
 	td = temp->td;
-	td_next = td_first = temp->td_next;
+	td_next = temp->td_next;
 
 	while (1) {
 
@@ -1702,10 +1702,21 @@ restart:
 			/* BEI: Interrupts are inhibited until EOT */
 			dword = XHCI_TRB_3_CHAIN_BIT | XHCI_TRB_3_CYCLE_BIT |
 			  XHCI_TRB_3_BEI_BIT |
-			  XHCI_TRB_3_TYPE_SET(temp->trb_type) |
 			  XHCI_TRB_3_TBC_SET(temp->tbc) |
 			  XHCI_TRB_3_TLBPC_SET(temp->tlbpc);
 
+			if (first_trb != 0) {
+				first_trb = 0;
+				dword |= XHCI_TRB_3_TYPE_SET(temp->trb_type);
+				/*
+				 * Remove cycle bit from the first TRB
+				 * if we are stepping them:
+				 */
+				if (temp->step_td != 0)
+					dword &= ~XHCI_TRB_3_CYCLE_BIT;
+			} else {
+				dword |= XHCI_TRB_3_TYPE_SET(XHCI_TRB_TYPE_NORMAL);
+			}
 			if (temp->trb_type == XHCI_TRB_TYPE_ISOCH) {
 				if (temp->do_isoc_sync != 0) {
 					temp->do_isoc_sync = 0;
@@ -1797,9 +1808,6 @@ restart:
 
 	/* need to force an interrupt if we are stepping the TRBs */
 	if ((temp->direction & UE_DIR_IN) != 0 && temp->multishort == 0) {
-		/* remove cycle bit from first TRB if we are stepping them */
-		if (temp->step_td)
-			td_first->td_trb[0].dwTrb3 &= ~htole32(XHCI_TRB_3_CYCLE_BIT);
 		/* make sure the last LINK event generates an interrupt */
 		td->td_trb[td->ntrb].dwTrb3 &= ~htole32(XHCI_TRB_3_BEI_BIT);
 	}