svn commit: r253719 - in head: sys/conf sys/dev/watchdog sys/libkern sys/sys usr.sbin/watchdogd

[Alfred Perlstein]

On 7/30/13 4:24 AM, Ulrich Spörlein wrote:
> On Sat, 2013-07-27 at 20:47:02 +0000, Alfred Perlstein wrote:
>> Author: alfred
>> Date: Sat Jul 27 20:47:01 2013
>> New Revision: 253719
>> URL: http://svnweb.freebsd.org/changeset/base/253719
>>
>> Log:
>>    Fix watchdog pretimeout.
> Alfred,
>
> this broken the build and hasn't been fixed for almost three days now.
> What's up with that? How was this change tested before commit?
>
> ===> usr.sbin/watchdogd (all)
> cc  -O2 -pipe  -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c /data/src/freebsd-head/usr.sbin/watchdogd/watchdogd.c
> /data/src/freebsd-head/usr.sbin/watchdogd/watchdogd.c:777:18: error: comparison of integers of different signs: 'u_int' (aka 'unsigned int') and 'time_t' (aka 'int') [-Werror,-Wsign-compare]
>                  if (pretimeout >= ts.tv_sec) {
>                      ~~~~~~~~~~ ^  ~~~~~~~~~
> 1 error generated.
> *** Error code 1
>
Yikes!  What?

I did test this a ton of times.  My apologies to all.

Let me see what I can do.

-Alfred