svn commit: r253210 - in head/sys: conf netinet

Ulrich Spörlein uqs at FreeBSD.org
Mon Jul 15 09:36:18 UTC 2013


Hey Andre,

I don't see why this commit triggers it, but Coverity Scan found a new
resource leak in this file. syncache_expand() will leak *s when line
1071 is reached. The "failed:" case below correctly frees the resources.

1068/* how do we find the inp for the new socket? */
        22. Condition "sc != &scs", taking true branch
1069        if (sc != &scs)
1070                syncache_free(sc);
        
CID null (#1 of 1): Resource leak (RESOURCE_LEAK)
23. leaked_storage: Variable "s" going out of scope leaks the storage it points to.
1071        return (1);
1072failed:
1073        if (sc != NULL && sc != &scs)
1074                syncache_free(sc);
1075        if (s != NULL)
1076                free(s, M_TCPLOG);
1077        *lsop = NULL;
1078        return (0);
1079}

This has no CID yet ...

Cheers,
Uli


More information about the svn-src-all mailing list