svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt

Mikolaj Golub trociny at FreeBSD.org
Sat Jul 13 18:34:02 UTC 2013


On Sat, Jul 13, 2013 at 11:04:23AM -0700, Craig Rodrigues wrote:

> Can you try this combination of patches:
> 
> (1)  Combine Adrian and Marko's patches, but omit Marko's changes to
> kldload/kldunload:
> 
> http://people.freebsd.org/~rodrigc/vnet-patch-adrian+marko.txt
> 
> (2)  Revert my Bluetooth patch:
> 
> http://people.freebsd.org/~rodrigc/patch-revert-GRN-253255.txt

Currently I don't have any pluggable device so my testing would not be
very useful. I tried Marko's patch to test kldload/kldunload change,
which is not in your patch.

Concerning your combined patch, as I said previously I don't like very
much that dance with is_default_vnet. What is a purpose of it? As for
me, it only makes the code less readable. I would just set curvnet to
vnet0, as it is in Marko's patch.

-- 
Mikolaj Golub


More information about the svn-src-all mailing list