svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt
Mikolaj Golub
trociny at FreeBSD.org
Sat Jul 13 07:31:25 UTC 2013
On Fri, Jul 12, 2013 at 10:40:08PM -0700, Adrian Chadd wrote:
> Here's what I have running on my stable/9 VIMAGE laptop.
>
> http://people.freebsd.org/~adrian/ath/20130712-vimage-default-attach-detach.diff
>
> How's this look to put into -HEAD?
Your patch looks similar to Marko's:
http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20121115/0824ca85/attachment.diff
Marko took your idea of setting vnet0 context in
device_probe_and_attach(), although there is no is_default_vnet check,
and I also think it is not necessary here -- just unconditionally set
vnet0 is ok.
Also, as I understand, after handling vnet context in
device_probe_and_attach(), there is no need in curvnet setting in
kldload/kldunload, and Marko removed it.
In net/if.c, similarly to you, Marko sets vnet context in if_detach(),
but also in if_free(), so this would be good to commit too (I suppose
Marko had good reasons to do this).
I can't comment the netgraph related parts of your patch as I have no
idea what is going on here. Though I think this could be committed
separately if it is needed.
--
Mikolaj Golub
More information about the svn-src-all
mailing list