svn commit: r253255 - head/sys/netgraph/bluetooth/drivers/ubt

Mikolaj Golub trociny at FreeBSD.org
Fri Jul 12 20:27:18 UTC 2013


On Fri, Jul 12, 2013 at 11:39:34AM -0700, Craig Rodrigues wrote:
> I like your patch.  It may be worth having one more Netgraph person review
> it and give a sanity check, but
> I think we should commit your patch ASAP.
> I am new to VNET, but I am wondering if in your patch we can KASSERT if
> node->vnet is NULL.  That would make
> things easier to debug.
> 
> The part of my patch which which does CURVNET_SET is still necessary upon
> attach in Bluetooth.
> However, with your patch, we can get rid of the part of my patch which does
> CURVNET_SET upon Bluetooth detach.

Some time ago there was a long discussion about VIMAGE issue with
hotplugabble network devices:

http://lists.freebsd.org/pipermail/freebsd-hackers/2012-October/040784.html

(I wander why Adrian did not mention it as he was deeply involved)

Then Marko came up with a patch that mihght fix the issue in a more
generic way:

http://lists.freebsd.org/pipermail/freebsd-hackers/2012-November/041120.html

Unfortunately it was not tested. I think it would be very interesting
to try it with hotplugabble devices. (I don't have any so can't test).

-- 
Mikolaj Golub


More information about the svn-src-all mailing list