svn commit: r252514 - head/sbin/swapon

[Florent Peterschmitt]

Le 02/07/2013 19:34, Xin LI a écrit :
> Author: delphij
> Date: Tue Jul  2 17:34:34 2013
> New Revision: 252514
> URL: http://svnweb.freebsd.org/changeset/base/252514
> 
> Log:
>   Plug a memory leak.
> 
> Modified:
>   head/sbin/swapon/swapon.c
> 
> Modified: head/sbin/swapon/swapon.c
> ==============================================================================
> --- head/sbin/swapon/swapon.c	Tue Jul  2 17:17:42 2013	(r252513)
> +++ head/sbin/swapon/swapon.c	Tue Jul  2 17:34:34 2013	(r252514)

Hi,

Wouldn't be simpler to do a "goto" somewhere in the code to do the
free() and return(NULL) instead of copying those instructions at each case ?

It's just a question.

-- 
Florent Peterschmitt           | Please:
florent at peterschmitt.fr        |  * Avoid HTML/RTF in E-mail.
+33 (0)6 64 33 97 92           |  * Send PDF for documents.
http://florent.peterschmitt.fr | Thank you :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20130702/d68fe13a/attachment.sig>