svn commit: r245494 - head/bin/pwait

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 01/16/13 09:47, Eitan Adler wrote:
> On 16 January 2013 01:49, Xin LI <delphij at gmail.com> wrote:
>> This doesn't seem right -- you should never release memory before
>> exit, especially for memory allocated in main(), unless this
>> "main" is intended for different purpose like a monolithic shell
>> that wants to avoid exec(). Note that pwait(1) have multiple exit
>> points I don't think it's practical.
> 
> ...
> 
> There have been multiple conversations about this: on hackers, on
> the commit lists, and on the clang analyzer lists.
> 
> I don't care much how the final code looks: with either free or
> return but please make sure that scan-build finds no warnings.

Yes I did.  Using exit(3) tells clang that this is the final exit and
thus eliminates the warning.

It sounds like a bug (or arguably a feature) that clang does not
recognize return in main()s...

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJQ9u1oAAoJEG80Jeu8UPuzNF8IAIuLlVRawKYSgvW0Qqf01Pt3
l6UvBc/6U0LBVTgRUVNVDqlvjyP93pcnMpDGiGqGf/1TbizWhahIayB7NxPQoiqE
8iFRYxhMXJL+pMgckgB3twGOrXkSCCaWhudmNlx9pPXac2dqCFF4PXugVAV1xVVx
JfdkCHhSMH+MVhzxkPN4XtZTvH288UiaeWRsCLEzVwylYOvMqslW0WhJYRCpn6ee
XXeBBN8D/aYOPehHZ7/UhzatxIUOQMaW509rituOZ6IKF5PAHhPQsXwIRiG85mIb
tbppR2Pwm0wg/mOFcr44P/zhdeiR4+JW1Tk65mmleoLsq8aufzT/OjJnVcD6860=
=nsUL
-----END PGP SIGNATURE-----