svn commit: r244899 - head/sys/mips/beri

[Andrew Turner]

On Fri, 04 Jan 2013 12:10:54 -0500
Nathan Whitehorn <nwhitehorn at freebsd.org> wrote:

> On 01/02/13 16:02, Andrew Turner wrote:
> > The patch looks good. From my reading of [1] the compatible value
> > should be something like "mips,mips4k" as it's value is of the form
> > "<manufacturer>,<model>".
> >
> > I have been thinking the best way of merging these almost identical
> > decode functions. Linux appears to do it by providing a
> > per-controller function that can translate between the interrupt
> > spec and the configuration allowing them to have a generic parsing
> > function that doesn't need to check if the controller is
> > compatible. I would like us to have something similar as it will
> > remove the duplicate function.
> >
> > Andrew
> >
> > [1] http://www.devicetree.org/Device_Tree_Usage
> PowerPC does something very much like this currently in the real OF
> case. Looking at the contents of /sys/dev/fdt, it seems like there is
> a lot of code duplication in particular with interrupts and PCI
> handling compared to the equivalent parts of /sys/dev/ofw (and a few
> extra things that are actually MI like /sys/powerpc/ofw_pci*). It
> would be very nice if we could make FDT follow the normal OF
> codepaths instead of (partially) reinventing the wheel.
> -Nathan

Ok, I'll look to figure out how much of this code we can use with FDT.

Andrew