svn commit: r244899 - head/sys/mips/beri

[Robert N. M. Watson]

On 1 Jan 2013, at 19:17, Andrew Turner wrote:

>> @@ -76,6 +85,17 @@ mips_init(void)
>> {
>> 	int i;
>> 
>> +#ifdef FDT
>> +#ifndef FDT_DTB_STATIC
>> +#error	"mips_init with FDT requires FDT_DTB_STATIC"
>> +#endif
>> +
>> +	if (OF_install(OFW_FDT, 0) == FALSE)
>> +		while (1);
>> +	if (OF_init(&fdt_static_dtb) != 0)
>> +		while (1);
>> +#endif
>> +
>> 	for (i = 0; i < 10; i++) {
>> 		phys_avail[i] = 0;
>> 	}
>> 
>> 
> 
> This looks like it is too late in the boot process. If you are using
> FDT you will need to use the FDT uart which is initialised in cninit.

Hi Andrew:

The current BERI low-level UART, as with several others in MIPS-space, has excessively intimate knowledge of the location of the console UART instance. Once we fix the console driver, you're right -- it will need to move to platform_init() or similar.

> You will also need a patch similar to the untested one attached to fix the build.

Thanks -- I had actually committed an identical patch to Perforce this morning, but failed to merge it to head. It would be nice if we didn't have to conditionally include headers.

Robert