svn commit: r247069 - head/sys/dev/mcd

Warner Losh imp at FreeBSD.org
Thu Feb 21 02:34:05 UTC 2013


Author: imp
Date: Thu Feb 21 02:34:04 2013
New Revision: 247069
URL: http://svnweb.freebsd.org/changeset/base/247069

Log:
  The other giant locked storage drivers have removed splbio(), for the
  most part, so remove it here too. Anybody locking this driver will need
  far more than locks where splbio() were, so remove these nops.

Modified:
  head/sys/dev/mcd/mcd.c

Modified: head/sys/dev/mcd/mcd.c
==============================================================================
--- head/sys/dev/mcd/mcd.c	Thu Feb 21 00:40:08 2013	(r247068)
+++ head/sys/dev/mcd/mcd.c	Thu Feb 21 02:34:04 2013	(r247069)
@@ -289,7 +289,6 @@ static void
 mcdstrategy(struct bio *bp)
 {
 	struct mcd_softc *sc;
-	int s;
 
 	sc = (struct mcd_softc *)bp->bio_dev->si_drv1;
 
@@ -318,9 +317,7 @@ mcdstrategy(struct bio *bp)
 	bp->bio_resid = 0;
 
 	/* queue it */
-	s = splbio();
 	bioq_disksort(&sc->data.head, bp);
-	splx(s);
 
 	/* now check whether we can perform processing */
 	mcd_start(sc);
@@ -338,10 +335,8 @@ static void
 mcd_start(struct mcd_softc *sc)
 {
 	struct bio *bp;
-	int s = splbio();
 
 	if (sc->data.flags & MCDMBXBSY) {
-		splx(s);
 		return;
 	}
 
@@ -350,10 +345,8 @@ mcd_start(struct mcd_softc *sc)
 		/* block found to process, dequeue */
 		/*MCD_TRACE("mcd_start: found block bp=0x%x\n",bp,0,0,0);*/
 		sc->data.flags |= MCDMBXBSY;
-		splx(s);
 	} else {
 		/* nothing to do */
-		splx(s);
 		return;
 	}
 


More information about the svn-src-all mailing list