svn commit: r246787 - stable/8/sys/dev/syscons

Hans Petter Selasky hselasky at FreeBSD.org
Thu Feb 14 11:25:08 UTC 2013


Author: hselasky
Date: Thu Feb 14 11:25:07 2013
New Revision: 246787
URL: http://svnweb.freebsd.org/changeset/base/246787

Log:
  MFC r246397:
  
  Make sure that all mouse buttons are released when clients
  using /dev/consolectl close. This fixes a problem where if
  a USB mouse is detached while a button is pressed, that
  button is never released.

Modified:
  stable/8/sys/dev/syscons/syscons.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/syscons/   (props changed)

Modified: stable/8/sys/dev/syscons/syscons.c
==============================================================================
--- stable/8/sys/dev/syscons/syscons.c	Thu Feb 14 10:48:08 2013	(r246786)
+++ stable/8/sys/dev/syscons/syscons.c	Thu Feb 14 11:25:07 2013	(r246787)
@@ -234,11 +234,13 @@ static struct ttydevsw sc_ttydevsw = {
 };
 
 static d_ioctl_t	consolectl_ioctl;
+static d_close_t	consolectl_close;
 
 static struct cdevsw consolectl_devsw = {
 	.d_version	= D_VERSION,
-	.d_flags	= D_NEEDGIANT,
+	.d_flags	= D_NEEDGIANT | D_TRACKCLOSE,
 	.d_ioctl	= consolectl_ioctl,
+	.d_close	= consolectl_close,
 	.d_name		= "consolectl",
 };
 
@@ -1512,6 +1514,23 @@ consolectl_ioctl(struct cdev *dev, u_lon
 	return sctty_ioctl(dev->si_drv1, cmd, data, td);
 }
 
+static int
+consolectl_close(struct cdev *dev, int flags, int mode, struct thread *td)
+{
+#ifndef SC_NO_SYSMOUSE
+	mouse_info_t info;
+	memset(&info, 0, sizeof(info));
+	info.operation = MOUSE_ACTION;
+
+	/*
+	 * Make sure all buttons are released when moused and other
+	 * console daemons exit, so that no buttons are left pressed.
+	 */
+	(void) sctty_ioctl(dev->si_drv1, CONS_MOUSECTL, (caddr_t)&info, td);
+#endif
+	return (0);
+}
+
 static void
 sc_cnprobe(struct consdev *cp)
 {


More information about the svn-src-all mailing list