svn commit: r246614 - head/sys/dev/usb/wlan

John Baldwin jhb at freebsd.org
Mon Feb 11 21:12:04 UTC 2013


On Sunday, February 10, 2013 5:36:17 am Hans Petter Selasky wrote:
> Author: hselasky
> Date: Sun Feb 10 10:36:16 2013
> New Revision: 246614
> URL: http://svnweb.freebsd.org/changeset/base/246614
> 
> Log:
>   - Streamline detach logic in wlan drivers, so that
>     freed memory cannot be used during detach.
>   - Remove all panic() calls from the urtw driver because
>     panic() is not appropriate here.
>   - Remove redundant checks for device detached in
>     device detach callbacks.
>   - Use DEVMETHOD_END to mark end of device methods.

Using a detached flag to bail from ioctl generally means you are doing things 
wrong in detach.  The correct solution is to always detach your ifnet first, 
then start tearing down other state.  In general with device detach routines 
the first order of business is removing external references such as character 
devices, ifnets, etc. and only start shutting down the hardware and releasing 
state once those steps have completed.

-- 
John Baldwin


More information about the svn-src-all mailing list