svn commit: r246278 - head/usr.sbin/crunch/crunchide

[Pedro Giffuni]

Hi Eitan;


----- Messaggio originale -----
> Da: Eitan Adler 

> 
> On 2 February 2013 20:54, Pedro F. Giffuni <pfg at freebsd.org> wrote:
>>  Author: pfg
>>  Date: Sun Feb  3 01:54:25 2013
>>  New Revision: 246278
>>  URL: http://svnweb.freebsd.org/changeset/base/246278
>> 
>>  Log:
>>    crunch: Sync some NetBSD changes
>> 
>>    Fix a couple of free's in previous commit.
>> 
>>    Obtained from:        NetBSD
>>    MFC after:    1 week
>> 
>>  Modified:
>>    head/usr.sbin/crunch/crunchide/exec_elf32.c
>> 
>>  Modified: head/usr.sbin/crunch/crunchide/exec_elf32.c
>> 
> ==============================================================================
>>  --- head/usr.sbin/crunch/crunchide/exec_elf32.c Sun Feb  3 01:22:28 2013    
>     (r246277)
>>  +++ head/usr.sbin/crunch/crunchide/exec_elf32.c Sun Feb  3 01:54:25 2013    
>     (r246278)
>>  @@ -384,6 +384,8 @@ out:
>>          if (symtabp != NULL)
>>                  free(symtabp);
>>          if (strtabp != NULL)
>>  +               free(strtabp);
>>  +       if (nstrtabp != NULL)
>>                  free(nstrtabp);
> 
> Why bother checking for NULL here?   7.22.2.3.2 says that free(NULL)
> results in no action.
>

You are right. I was just copying the NetBSD code blindly.

I will clean that tomorrow when I bring the mclinker fixes.

Pedro.