svn commit: r259738 - releng/10.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Pawel Jakub Dawidek pjd at FreeBSD.org
Sun Dec 22 20:31:41 UTC 2013


Author: pjd
Date: Sun Dec 22 20:31:40 2013
New Revision: 259738
URL: http://svnweb.freebsd.org/changeset/base/259738

Log:
  MFC r259734:
  
  MFV r258923: 4188 assertion failed in dmu_tx_hold_free(): dn_datablkshift != 0
  
  illumos/illumos-gate at bb411a08b05466bfe0c7095b6373bbc1587e259a
  
  Approved by:	re (gjb)

Modified:
  releng/10.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c
Directory Properties:
  releng/10.0/   (props changed)

Modified: releng/10.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c
==============================================================================
--- releng/10.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c	Sun Dec 22 20:29:59 2013	(r259737)
+++ releng/10.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c	Sun Dec 22 20:31:40 2013	(r259738)
@@ -635,9 +635,16 @@ dmu_tx_hold_free(dmu_tx_t *tx, uint64_t 
 		uint64_t start = off >> shift;
 		uint64_t end = (off + len) >> shift;
 
-		ASSERT(dn->dn_datablkshift != 0);
 		ASSERT(dn->dn_indblkshift != 0);
 
+		/*
+		 * dnode_reallocate() can result in an object with indirect
+		 * blocks having an odd data block size.  In this case,
+		 * just check the single block.
+		 */
+		if (dn->dn_datablkshift == 0)
+			start = end = 0;
+
 		zio = zio_root(tx->tx_pool->dp_spa,
 		    NULL, NULL, ZIO_FLAG_CANFAIL);
 		for (uint64_t i = start; i <= end; i++) {


More information about the svn-src-all mailing list