svn commit: r259521 - head/sys/fs/fifofs

[Konstantin Belousov]

Author: kib
Date: Tue Dec 17 17:28:02 2013
New Revision: 259521
URL: http://svnweb.freebsd.org/changeset/base/259521

Log:
  Do not allow O_EXEC opens for fifo, return EINVAL.
  
  Besides not making sense, open(O_EXEC) for fifo creates fifoinfo with
  zero readers and writers counts, which causes premature free of pipes.
  
  Reported and tested by:	pho
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/sys/fs/fifofs/fifo_vnops.c

Modified: head/sys/fs/fifofs/fifo_vnops.c
==============================================================================
--- head/sys/fs/fifofs/fifo_vnops.c	Tue Dec 17 16:45:19 2013	(r259520)
+++ head/sys/fs/fifofs/fifo_vnops.c	Tue Dec 17 17:28:02 2013	(r259521)
@@ -143,7 +143,7 @@ fifo_open(ap)
 	fp = ap->a_fp;
 	td = ap->a_td;
 	ASSERT_VOP_ELOCKED(vp, "fifo_open");
-	if (fp == NULL)
+	if (fp == NULL || (ap->a_mode & FEXEC) != 0)
 		return (EINVAL);
 	if ((fip = vp->v_fifoinfo) == NULL) {
 		error = pipe_named_ctor(&fpipe, td);