svn commit: r259031 - head/sys/dev/usb/wlan

John Baldwin jhb at freebsd.org
Fri Dec 6 16:31:57 UTC 2013


On Friday, December 06, 2013 10:27:09 am John Baldwin wrote:
> On Friday, December 06, 2013 10:17:29 am Kevin Lo wrote:
> > Author: kevlo
> > Date: Fri Dec  6 15:17:28 2013
> > New Revision: 259031
> > URL: http://svnweb.freebsd.org/changeset/base/259031
> > 
> > Log:
> >   Replace the magic numbers with something more readable.
> > 
> > Modified:
> >   head/sys/dev/usb/wlan/if_run.c
> >   head/sys/dev/usb/wlan/if_runreg.h
> > 
> > Modified: head/sys/dev/usb/wlan/if_run.c
> > 
> 
==============================================================================
> > --- head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:15:58 2013	(r259030)
> > +++ head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:17:28 2013	(r259031)
> > @@ -4530,7 +4530,7 @@ run_rt5390_bbp_init(struct run_softc *sc
> >  
> >  	/* Avoid data lost and CRC error. */
> >  	run_bbp_read(sc, 4, &bbp4);
> > -	run_bbp_write(sc, 4, bbp4 | 0x40);
> > +	run_bbp_write(sc, 4, bbp | RT5390_MAC_IF_CTRL);
> 
> The s/bbp4/bbp/ here looks like a bug?

Ah, your larger patch after this changed the read to use bbp instead of
bbp4.

-- 
John Baldwin


More information about the svn-src-all mailing list