svn commit: r254949 - in head/cddl: lib/libzpool usr.bin/ztest usr.sbin/zdb

[Will Andrews]

Author: will
Date: Tue Aug 27 04:01:31 2013
New Revision: 254949
URL: http://svnweb.freebsd.org/changeset/base/254949

Log:
  Build all ZFS testing & debugging tools with -g.
  
  These programs and everything using libzpool rely on the embedded asserts to
  verify the correctness of operations.  Given that, the core dumps would be
  useless without debug symbols.

Modified:
  head/cddl/lib/libzpool/Makefile
  head/cddl/usr.bin/ztest/Makefile
  head/cddl/usr.sbin/zdb/Makefile

Modified: head/cddl/lib/libzpool/Makefile
==============================================================================
--- head/cddl/lib/libzpool/Makefile	Tue Aug 27 03:49:47 2013	(r254948)
+++ head/cddl/lib/libzpool/Makefile	Tue Aug 27 04:01:31 2013	(r254949)
@@ -64,7 +64,9 @@ NO_PROFILE=
 
 CSTD=	c99
 
-CFLAGS+=	-DDEBUG=1
-#DEBUG_FLAGS+=	-g
+# Since there are many asserts in this library, it makes no sense to compile
+# it without debugging.
+
+CFLAGS+=	-g -DDEBUG=1
 
 .include <bsd.lib.mk>

Modified: head/cddl/usr.bin/ztest/Makefile
==============================================================================
--- head/cddl/usr.bin/ztest/Makefile	Tue Aug 27 03:49:47 2013	(r254948)
+++ head/cddl/usr.bin/ztest/Makefile	Tue Aug 27 04:01:31 2013	(r254949)
@@ -25,7 +25,8 @@ LDADD=	-lgeom -lm -lnvpair -lumem -lzpoo
 
 CSTD=	c99
 
-CFLAGS+= -DDEBUG=1
-#DEBUG_FLAGS+=	-g
+# Since there are many asserts in this program, it makes no sense to compile
+# it without debugging.
+CFLAGS+= -g -DDEBUG=1
 
 .include <bsd.prog.mk>

Modified: head/cddl/usr.sbin/zdb/Makefile
==============================================================================
--- head/cddl/usr.sbin/zdb/Makefile	Tue Aug 27 03:49:47 2013	(r254948)
+++ head/cddl/usr.sbin/zdb/Makefile	Tue Aug 27 04:01:31 2013	(r254949)
@@ -27,7 +27,8 @@ DPADD=	${LIBGEOM} ${LIBM} ${LIBNVPAIR} $
 	${LIBUUTIL} ${LIBZFS_CORE} ${LIBZFS} ${LIBZPOOL}
 LDADD=	-lgeom -lm -lnvpair -lpthread -lumem -luutil -lzfs_core -lzfs -lzpool
 
-CFLAGS+=	-DDEBUG=1
-#DEBUG_FLAGS+=	-g
+# Since there are many asserts in this program, it makes no sense to compile
+# it without debugging.
+CFLAGS+=	-g -DDEBUG=1
 
 .include <bsd.prog.mk>