svn commit: r254684 - head/usr.sbin/rtadvd

Dag-Erling Smørgrav des at FreeBSD.org
Fri Aug 23 10:57:06 UTC 2013


Author: des
Date: Fri Aug 23 10:57:05 2013
New Revision: 254684
URL: http://svnweb.freebsd.org/changeset/base/254684

Log:
  Set the back pointer from the prefix to the interface before adding
  the prefix to the interface's prefix list.  This shouldn't make a
  difference, since rtadvd(8) is single-threaded, but I've seen it crash
  in delete_prefix() with pfx_rainfo == NULL, and this is the only place
  where a prefix can be added to the list with a NULL pfx_rainfo.
  
  MFC after:	3 days

Modified:
  head/usr.sbin/rtadvd/config.c

Modified: head/usr.sbin/rtadvd/config.c
==============================================================================
--- head/usr.sbin/rtadvd/config.c	Fri Aug 23 08:26:52 2013	(r254683)
+++ head/usr.sbin/rtadvd/config.c	Fri Aug 23 10:57:05 2013	(r254684)
@@ -1125,9 +1125,9 @@ add_prefix(struct rainfo *rai, struct in
 	pfx->pfx_onlinkflg = ipr->ipr_raf_onlink;
 	pfx->pfx_autoconfflg = ipr->ipr_raf_auto;
 	pfx->pfx_origin = PREFIX_FROM_DYNAMIC;
+	pfx->pfx_rainfo = rai;
 
 	TAILQ_INSERT_TAIL(&rai->rai_prefix, pfx, pfx_next);
-	pfx->pfx_rainfo = rai;
 
 	syslog(LOG_DEBUG, "<%s> new prefix %s/%d was added on %s",
 	    __func__,


More information about the svn-src-all mailing list