svn commit: r254600 - head/lib/libutil

Andrey Chernov ache at freebsd.org
Thu Aug 22 10:07:04 UTC 2013


On 22.08.2013 14:01, Andrey Chernov wrote:
> On 22.08.2013 1:37, Jilles Tjoelker wrote:
>>>         if (number == UINTMAX_MAX && errno == ERANGE) {
>>>                 return (-1);
>>>         }
>>>  
>>> +       if (errno == 0)
>>> +               errno = saved_errno;
>>> +
>> This looks good to me.
>>
> 
> Just being nitpicking) number == UINTMAX_MAX check is unneeded.
> 
Sorry for misguiding, forget it.
The check is needed, other functions inside strtoumax() (FIX_LOCALE,
isspace) may set errno in theory.

-- 
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r


More information about the svn-src-all mailing list