svn commit: r254286 - head/sys/fs/ext2fs

Dimitry Andric dim at freebsd.org
Wed Aug 14 07:25:19 UTC 2013


On Aug 14, 2013, at 09:14, Juli Mallett <jmallett at FreeBSD.org> wrote:
> On Wed, Aug 14, 2013 at 12:11 AM, Dimitry Andric <dim at freebsd.org> wrote:
> This still fails on arches where int64_t is aliased to long long
> (basically, the 32-bit arches).  Since using PRId64 is apparently
> frowned upon, the easiest solution is to cast the 'start' and 'last'
> variables to long long, and print them using %lld.
> 
> That can't be the easiest solution, it's not even that easy :)  It seems like intmax_t or uintmax_t as appropriate and cast to %jd or %ju respectively would be better.

I was simply looking at the surrounding code, and that already casts
several items to long long.  So I wanted to keep the style there. :-)

-Dimitry



More information about the svn-src-all mailing list