svn commit: r249849 - in head/sys/dev: hptmv mpt

[Andrey Chernov]

On 25.04.2013 12:26, Ronald Klop wrote:
> Hi,
> 
> Maybe I need more coffee, but I don't see a difference between the if
> and the else statements in the hptmv file.

shutdown_kproc vs. kproc_shutdown

> 
> Regards,
> Ronald.
> 
> On Wed, 24 Apr 2013 21:00:45 +0200, Alexander Motin <mav at freebsd.org>
> wrote:
> 
>> Author: mav
>> Date: Wed Apr 24 19:00:45 2013
>> New Revision: 249849
>> URL: http://svnweb.freebsd.org/changeset/base/249849
>>
>> Log:
>>   Move hptmv and mpt drivers shutdown a bit later to the
>> SHUTDOWN_PRI_LAST
>>   stage of shutdown_post_sync.  That should allow CAM to do final
>> cache flush
>>   at the SHUTDOWN_PRI_DEFAULT without using polling magic.
>>  MFC after:    3 days
>>
>> Modified:
>>   head/sys/dev/hptmv/entry.c
>>   head/sys/dev/mpt/mpt_pci.c
>>
>> Modified: head/sys/dev/hptmv/entry.c
>> ==============================================================================
>>
>> --- head/sys/dev/hptmv/entry.c    Wed Apr 24 18:30:32 2013    (r249848)
>> +++ head/sys/dev/hptmv/entry.c    Wed Apr 24 19:00:45 2013    (r249849)
>> @@ -2605,9 +2605,11 @@ launch_worker_thread(void)
>>       * hpt_worker_thread needs to be suspended after shutdown sync,
>> when fs sync finished.
>>       */
>>  #if (__FreeBSD_version < 500043)
>> -    EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc,
>> hptdaemonproc, SHUTDOWN_PRI_FIRST);
>> +    EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc,
>> hptdaemonproc,
>> +        SHUTDOWN_PRI_LAST);
>>  #else
>> -    EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown,
>> hptdaemonproc, SHUTDOWN_PRI_FIRST);
>> +    EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown,
>> hptdaemonproc,
>> +        SHUTDOWN_PRI_LAST);
>>  #endif
>>  }
>>  /*
>>
>> Modified: head/sys/dev/mpt/mpt_pci.c
>> ==============================================================================
>>
>> --- head/sys/dev/mpt/mpt_pci.c    Wed Apr 24 18:30:32 2013    (r249848)
>> +++ head/sys/dev/mpt/mpt_pci.c    Wed Apr 24 19:00:45 2013    (r249849)
>> @@ -563,7 +563,7 @@ mpt_pci_attach(device_t dev)
>>      }
>>     mpt->eh = EVENTHANDLER_REGISTER(shutdown_post_sync, mpt_pci_shutdown,
>> -        dev, SHUTDOWN_PRI_DEFAULT);
>> +        dev, SHUTDOWN_PRI_LAST);
>>     if (mpt->eh == NULL) {
>>          mpt_prt(mpt, "shutdown event registration failed\n");
>> _______________________________________________
>> svn-src-all at freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/svn-src-all
>> To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"
> 


-- 
bitcoin:13fGiNutKNHcVSsgtGQ7bQ5kgUKgEQHn7N