svn commit: r249355 - head/lib/libkvm

[Juli Mallett]

On Thu, Apr 11, 2013 at 11:00 AM, Gleb Smirnoff <glebius at freebsd.org> wrote:
>   Bruce,
>
> On Thu, Apr 11, 2013 at 09:07:25PM +1000, Bruce Evans wrote:
> B> Just routine avoidance of namespace pollution.  This is easy in such a
> B> simple header.
>
> Sorry, with all respect, but I can't call including sys/types.h
> a namespace pollution.
>
> Ok, even you force me to name it that way, still I would prefer
> namespace pollution instead of handmade copy pasted typedefs.

But Gleb, making such changes unilaterally is a bit of a leap.  The
project has mostly accepted Bruce's wisdom about trying to minimize
and reduce namespace pollution.  Now, this isn't a standard header so
it's quite a bit less of a concern, but it's not no concern.  If you
think that we should reverse our trend on including
namespace-polluting headers in system headers, we should discuss that
on arch@, and it shouldn't be something that's done without any
discussion or consideration.

Should we expect further changes of this nature (and of the proposed
nature removing __size_t and __ssize_t use) if you make changes to
other headers as part of your work?  Are you going to add
<sys/types.h> to every header currently using <sys/_types.h> in a
single go, or will you be doing that a little at a time when making
functional changes?

Thanks,
Juli.