svn commit: r249355 - head/lib/libkvm

Bruce Evans brde at optusnet.com.au
Thu Apr 11 08:49:12 UTC 2013


On Thu, 11 Apr 2013, Gleb Smirnoff wrote:

> On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
> B> > Modified:
> B> >  head/lib/libkvm/kvm.h
> B> >
> B> > Modified: head/lib/libkvm/kvm.h
> B> > ==============================================================================
> B> > --- head/lib/libkvm/kvm.h	Thu Apr 11 07:02:27 2013	(r249354)
> B> > +++ head/lib/libkvm/kvm.h	Thu Apr 11 07:30:49 2013	(r249355)
> B> > @@ -34,7 +34,7 @@
> B> > #define	_KVM_H_
> B> >
> B> > #include <sys/cdefs.h>
> B> > -#include <sys/_types.h>
> B>
> B> The __uintXX_t types are declared here, and should be used, like the
> B> __Xsize_t types already are.
>
> Why non-standard types should be used instead of standard ones?

Sometimes because the namespace doesn't allow the standard ones, but
here I was just saying to typedef just the standard ones that you need
(only uint64_t?) as is done for size_t and ssize_t.  Including
<sys/types.h> also turns the careful ifdefs for the latter into
no-ops.

Bruce


More information about the svn-src-all mailing list