svn commit: r246713 - in head/sys: arm/arm cam cam/ctl cam/scsi conf dev/aac dev/advansys dev/aha dev/ahb dev/ahci dev/aic dev/aic7xxx dev/amr dev/arcmsr dev/ata dev/buslogic dev/ciss dev/dpt dev/f...

[Ian Lepore]

On Tue, 2013-02-12 at 16:57 +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Tue Feb 12 16:57:20 2013
> New Revision: 246713
> URL: http://svnweb.freebsd.org/changeset/base/246713
> 
> Log:
>   Reform the busdma API so that new types may be added without modifying
>   every architecture's busdma_machdep.c.  It is done by unifying the
>   bus_dmamap_load_buffer() routines so that they may be called from MI
>   code.  The MD busdma is then given a chance to do any final processing
>   in the complete() callback.
>   
>   The cam changes unify the bus_dmamap_load* handling in cam drivers.
>   
>   The arm and mips implementations are updated to track virtual
>   addresses for sync().  Previously this was done in a type specific
>   way.  Now it is done in a generic way by recording the list of
>   virtuals in the map.
>   
>   Submitted by:	jeff (sponsored by EMC/Isilon)
>   Reviewed by:	kan (previous version), scottl,
>   	mjacob (isp(4), no objections for target mode changes)
>   Discussed with:	     ian (arm changes)
>   Tested by:	marius (sparc64), mips (jmallet), isci(4) on x86 (jharris),
>   	amd64 (Fabian Keil <freebsd-listen at fabiankeil.de>)
> 
> Added:
>   head/sys/kern/subr_bus_dma.c   (contents, props changed)
>   [...]

I've just discovered that _bus_dmamap_load_vlist() gets a compile
warning when building tinderbox on an i386 host, while building for PAE
and XEN:

cc1: warnings being treated as errors
/local/build/staging/freebsd/head/src/sys/kern/subr_bus_dma.c: In function '_bus_dmamap_load_vlist':
/local/build/staging/freebsd/head/src/sys/kern/subr_bus_dma.c:69: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

My build machine is i386 PAE running 8.3 (needs to be that old for our
build system at $work), so if this is a bogus error caused by building
-current on such a downlevel system, I appologize in advance for the
noise.

-- Ian