svn commit: r240822 - head/sys/geom

[Kenneth D. Merry]

On Thu, Sep 27, 2012 at 20:16:25 +0200, Pawel Jakub Dawidek wrote:
> On Wed, Sep 26, 2012 at 09:45:41PM +0200, Pawel Jakub Dawidek wrote:
> > On Wed, Sep 26, 2012 at 01:21:17PM -0600, Kenneth D. Merry wrote:
> > > Ahh.  How about using LIST_FOREACH_SAFE?  Would that address the problem at
> > > hand?  Are there any other races in there?
> > 
> > It depends. If one geom can hold more than one provider then it might be
> > racy, but from what I see there is always only one provider - there has
> > to be only one, because disk_destroy() destroys it and struct disk
> > represents always only one disk. If that's true then I see not reason to
> > have a loop in there. I'd change it to:
> > 
> > void
> > disk_gone(struct disk *dp)
> > {
> > 	struct g_geom *gp;
> > 	struct g_provider *pp;
> > 
> > 	gp = dp->d_geom;
> > 	if (gp != NULL) {
> > 		pp = LIST_FIRST(&gp->provider);
> > 		if (pp != NULL)
> > 			g_wither_provider(pp, ENXIO);
> > 	}
> > }
> 
> Final patch for review:
> 
> 	http://people.freebsd.org/~pjd/patches/geom_disk.c.3.patch

Looks good, thanks!

Ken
-- 
Kenneth Merry
ken at FreeBSD.ORG